-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter #30422
Copy link
Copy link
Open
Feature
Copy link
Labels
help wanteda good issue for the communitya good issue for the communityionfw-internship-2025type: feature requesta new feature, enhancement, or improvementa new feature, enhancement, or improvement
Description
Currently, any time ion-toolbar changes in appearance, a lot of screenshots have to be updated.
Most of them are only being updated because they include ion-toolbar for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.
The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:
- badge-basic
- button
- item
- list-header
- progress-bar
- searchbar
- toast
- toggle
Some of these might have one or two tests where ion-toolbar is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the ion-toolbar in the screenshot capture.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wanteda good issue for the communitya good issue for the communityionfw-internship-2025type: feature requesta new feature, enhancement, or improvementa new feature, enhancement, or improvement