feat(radio): add helperText and errorText properties#30162
Closed
brandyscarney wants to merge 14 commits intofeature-8.5from
Closed
feat(radio): add helperText and errorText properties#30162brandyscarney wants to merge 14 commits intofeature-8.5from
brandyscarney wants to merge 14 commits intofeature-8.5from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
thetaPC
approved these changes
Feb 26, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, fun fact: no duplicate announcement from VoiceOver using Firefox.
Contributor
There was a problem hiding this comment.
These look a bit weird without the checkmark. Recommendation to include them. I'm good either or.
Member
Author
BenOsodrac
approved these changes
Feb 27, 2025
Member
Author
|
We have decided not to implement this and only have the properties on the parent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Radio does not support helper and error text.
What is the new behavior?
Adds support for helper and error text, similar to input and textarea.
Does this introduce a breaking change?
Other information