feat(textarea): add styles for textarea solid fill#30685
Merged
Conversation
- fix some textarea ionic css vars usage; - create sheet for ionic.solid;
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
requested changes
Sep 22, 2025
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Great work! A few questions on some styles & a requested change for a variable that appears different in Figma. 👍
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
brandyscarney
requested changes
Sep 23, 2025
ShaneK
approved these changes
Sep 25, 2025
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Minor request, but not blocking. Looks good otherwise, great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information
fill
color
states