chore(): add updated snapshots#30721
Merged
brandyscarney merged 3 commits intoFW-6747from Oct 15, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Oct 8, 2025
Member
Author
There was a problem hiding this comment.
This change is expected now that the ionic theme uses the dark palette.
Member
Author
There was a problem hiding this comment.
This test looks the same on next the screenshot just hasn't been updated: https://ionic-framework-git-next-ionic1.vercel.app/src/components/tab-bar/test/basic?ionic:theme=ionic
2 tasks
brandyscarney
requested review from
OS-jacobbell
and removed request for
a team
OS-jacobbell
approved these changes
Oct 9, 2025
Contributor
OS-jacobbell
left a comment
OS-jacobbell
left a comment
There was a problem hiding this comment.
As long as some of those labels are supposed to be dark-on-dark, all the screenshots are there.
ShaneK
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the screenshot updates for #30708
Most of these screenshots were updated because the
ionictheme now uses the same colors as the other themes. I left comments on the ones that changed for other reasons explaining why.