feat(themes): add md theme tokens and update ionic theme to include semantic tokens#30734
Merged
brandyscarney merged 8 commits intoionic-modularfrom Oct 21, 2025
Merged
feat(themes): add md theme tokens and update ionic theme to include semantic tokens#30734brandyscarney merged 8 commits intoionic-modularfrom
brandyscarney merged 8 commits intoionic-modularfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Oct 17, 2025
| --ion-font-family: Roboto, "mdTestingFont", sans-serif; | ||
| font-family: Roboto, "mdTestingFont", sans-serif; | ||
| } | ||
|
|
||
| /* TODO(FW-6744): Remove this after adding the ios tokens */ |
Member
Author
There was a problem hiding this comment.
I thought I could remove these but Playwright still needs the iosTestingFont and mdTestingFont.
Member
Author
There was a problem hiding this comment.
It doesn't apply Roboto without the testing font in this file:
--ion-font-family: Roboto, "mdTestingFont", sans-serif;and it doesn't apply the apple font without this either:
--ion-font-family: -apple-system, BlinkMacSystemFont, "iosTestingFont", sans-serif;I thought maybe this code was outdated but it is still needed so I left it. We could look into removing it later.
Contributor
There was a problem hiding this comment.
That's weird, I wonder why it needs it. Thanks!
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Oct 17, 2025
ShaneK
approved these changes
Oct 20, 2025
Member
ShaneK
left a comment
There was a problem hiding this comment.
Just noticed a weird inconsistency, but it may be intentional. Otherwise looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
mdthemeionictheme redefines the base numeric tokensWhat is the new behavior?
configvalues into a separateconfigoption which uses theIonicConfiginterfaceformHighlighttoIonicConfigmdthemeionictheme and adds semantic tokens--ion-font-familyoverrides in favor of the tokensDoes this introduce a breaking change?