Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BenOsodrac
reviewed
Oct 28, 2025
...ustom/select.e2e.ts-snapshots/select-custom-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
Show resolved
Hide resolved
BenOsodrac
requested changes
Oct 28, 2025
Contributor
BenOsodrac
left a comment
BenOsodrac
left a comment
There was a problem hiding this comment.
@joselrio Looking at Figma, these seemed the expected tokens to use
Co-authored-by: Bernardo Cardoso <32780808+BenOsodrac@users.noreply.github.com>
Co-authored-by: Bernardo Cardoso <32780808+BenOsodrac@users.noreply.github.com>
joselrio
changed the title
joselrio
changed the title
BenOsodrac
approved these changes
Oct 28, 2025
brandyscarney
requested changes
Oct 29, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
The solid background looks good, but I think you need to change the select-text when it has a value (has-value class).
2 tasks
joselrio
added a commit
that referenced
this pull request
Oct 30, 2025
Issue number: resolves # --------- This is based on #30755 PR to try to clean up things. <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? - Select text color was not according design - Fill solid type was missing the background color ## What is the new behavior? - Added the expected color to the select text - Added missing background color variable to the fill solid type ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?