Skip to content

fix(radio-group): prevent DOMException and NotFoundError when filtering radios #30958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-jacobbell merged 3 commits into from
Feb 19, 2026
Merged

fix(radio-group): prevent DOMException and NotFoundError when filtering radios #30958

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c2a85f
chore(radio-group): remove div wrapper around radio-group slot
OS-jacobbell Feb 4, 2026
25bf49c
fix(stencil-config): set externalRuntime: false to apply build settin…
OS-jacobbell Feb 17, 2026
bfd16e9
chore(css): remove unneeded radio-group-wrapper style
OS-jacobbell Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions core/src/components/radio-group/radio-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,14 +353,7 @@ export class RadioGroup implements ComponentInterface {
class={mode}
>
{this.renderHintText()}
{/*
TODO(FW-6279): Wrapping the slot in a div is a workaround due to a
Stencil issue. Without the wrapper, the children radio will fire the
blur event on focus, instead of waiting for them to be blurred.
*/}
<div class="radio-group-wrapper">
Comment thread
OS-jacobbell marked this conversation as resolved.
<slot></slot>
</div>
<slot></slot>
</Host>
);
}
Expand Down
3 changes: 2 additions & 1 deletion core/stencil.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ export const config: Config = {
dest: 'components',
warn: true
}],
includeGlobalScripts: false
includeGlobalScripts: false,
externalRuntime: false,
},
{
type: 'docs-json',
Expand Down
Loading