-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(modal): add drag events for sheet and card modals #30962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
dbba21c
feat(modal): add drag events
thetaPC 962ba1c
refactor(modal): cleanup
thetaPC 7b597ba
test(modal): add drag events tests
thetaPC 9b2cde1
test(modal): update card snapshots
thetaPC ee4f499
feat(modal): expose drag event type
thetaPC 4fddd38
feat(modal): export ModalDragEventDetail for all frameworks
thetaPC 8af9626
feat(modal): add events to Vue overlays
thetaPC b6d5227
fix(vue): use correct event name
thetaPC 81221d4
feat(vue): update drag events logic
thetaPC 7223e05
Merge branch 'feature-8.8' of github.com:ionic-team/ionic-framework i…
thetaPC 9ff2658
fix(vue): delete correct keys
thetaPC 4bb9d83
feat(modal): update to predictedBreakpoint
thetaPC baea4c0
fix(modal): emit dragEnd on early return
thetaPC 0b73f03
feat(modal): add drag events to Angular common
thetaPC 47a377b
feat(modal): improve calculatePredictedBreakpoint
thetaPC f128fe7
Update core/src/components/modal/test/sheet/index.html
thetaPC f18849d
test(modal): remove testinfo
thetaPC 9384c75
docs(modal): remove double comment
thetaPC 8b033f6
feat(vue): remove long name version
thetaPC e2a2c9e
feat(modal): rename to snapBreakpoint
thetaPC d7a4aea
test(modal): check multiple event emits
thetaPC e32c1ac
test(modal): remove only
thetaPC b3ab42c
Merge branch 'feature-8.8' of github.com:ionic-team/ionic-framework i…
thetaPC 7cd96b7
Update packages/angular/common/src/overlays/modal.ts
thetaPC 726bb0d
feat(modal): add events to Angular common
thetaPC df6f9ea
revert(angular): test page
thetaPC bd9969d
revert(angular): test page
thetaPC 5a64358
docs(modal): add comments to interface
thetaPC 1f46d76
test(modal): update comments
thetaPC 070f5d5
Merge branch 'feature-8.8' into FW-7051
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.