-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(spinner): add recipe and tokens #31014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0a3f41d
feat(spinner): add recipe and tokens
thetaPC 5eee3a8
chore(spinner): run build
thetaPC 75a325a
test(color): update test page and snapshots
thetaPC 53d06e1
chore(spinner): delete old styles
thetaPC 78cfbba
test(spinner): update resize
thetaPC edb0414
test(spinner): remove diff term
thetaPC 2ffac3e
test(spinner): update spacing
thetaPC 3d89f21
feat(spinner): add recipe and config types
thetaPC 363cddf
feat(spinner): change class names
thetaPC 7b13706
test(spinner): update class
thetaPC b2a301a
refactor(spinner): remove plural type
thetaPC 5f0020c
test(spinner): update color snapshots
thetaPC 1179d40
refactor(theme): alphabetize imports
thetaPC 4f5ee31
docs(spinner, chip): update get value functions comments
thetaPC 2cd0043
Merge branch 'FW-6860' of github.com:ionic-team/ionic-framework into …
thetaPC 4c1c6d2
feat(spinner): change type names
thetaPC ee53528
refactor(spinner): change existing config type name
thetaPC 8019941
docs(chip, spinner): update method descriptions
thetaPC 0aef08c
feat(chip, spinner): remove old CSS variables
thetaPC cb80321
feat(spinner): rename internal interface
thetaPC 5388749
docs(breaking): update to include spinner
thetaPC de06eb8
feat(spinner): update --color to be internal
thetaPC 7e1f630
feat(button, spinner): update color when spinner is inside button
thetaPC 3c5afb3
fix(spinner): add missing token
thetaPC 8668db4
docs(chip, spinner): clarify how defaults work
thetaPC 528cb40
refactor(spinner): update return type
thetaPC e00d1f0
revert(BREAKING): leave radio group as is
thetaPC 062a7c7
docs(BREAKING): update chip to include ionic modular changes
thetaPC 95b1b41
docs(chip, spinner): add CSS variables to comments
thetaPC a8892a9
docs(chip): update logic comment
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was renamed, not sure why it's not showing as such. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| export interface SpinnerConfigs { | ||
| [spinnerName: string]: SpinnerConfig; | ||
| } | ||
|
|
||
| export interface SpinnerConfig { | ||
|
brandyscarney marked this conversation as resolved.
Outdated
|
||
| dur: number; | ||
| circles?: number; | ||
| lines?: number; | ||
| elmDuration?: boolean; | ||
| fn: (dur: number, index: number, total: number) => SpinnerData; | ||
| } | ||
|
|
||
| interface SpinnerData { | ||
|
brandyscarney marked this conversation as resolved.
|
||
| r?: number; | ||
| y1?: number; | ||
| y2?: number; | ||
| cx?: number; | ||
| cy?: number; | ||
| style: { [key: string]: string | undefined }; | ||
| viewBox?: string; | ||
| transform?: string; | ||
| } | ||
|
|
||
| export type IonSpinnerRecipe = { | ||
| color?: string; | ||
|
|
||
| lines?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
|
|
||
| small?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| sharp?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
|
|
||
| small?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| circular?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| crescent?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| // Sizes | ||
| size?: { | ||
| [K in IonSpinnerSizes]?: IonSpinnerSizeDefinition; | ||
| }; | ||
| }; | ||
|
|
||
| type IonSpinnerSizeDefinition = { | ||
| width?: string; | ||
| height?: string; | ||
| }; | ||
|
|
||
| export type IonSpinnerConfig = { | ||
| size?: IonSpinnerSizes; | ||
| }; | ||
|
|
||
| export type IonSpinnerSizes = 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge'; | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says:
But we still have this variable, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we discussed that it would be revisited as we add more components. Should I just remove them?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought that was just about the focus variables. I don't see a reason they can't override the
--coloron components directly? Developers might want it to be different than the global theme.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then they can override them per component by using
--ion-spinner-colorinstead of--color. I ended up removing the old CSS variables since having both might be confusing of when to use them, the same for chip: 0aef08c and 7e1f630