Skip to content

fix(typography): add missing rule on ionic theme for ios dynamic type #31031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenOsodrac merged 4 commits into from
Mar 24, 2026
+10 −2
Merged

fix(typography): add missing rule on ionic theme for ios dynamic type #31031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6decb4
add missing rule on ionic theme
BenOsodrac Mar 23, 2026
bce711c
fix lint
BenOsodrac Mar 23, 2026
0eff320
rename var
BenOsodrac Mar 23, 2026
58c9b0d
Merge branch 'next' into ROU-12556-v2
gnbm Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/css/ionic/core.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}

html {
--ionic-dynamic-font: -apple-system-body;
--ion-dynamic-font: -apple-system-body;
}

body {
Expand Down
10 changes: 9 additions & 1 deletion core/src/css/ionic/typography.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
@use "../../themes/ionic/ionic.globals.scss" as globals;

// TODO(ROU-10833): add font loading solution here, as a @font-face, base64 or cdn
html {
font-family: globals.$ion-font-family;
}

// Dynamic Type is an iOS-only feature, so
// this should only be enabled on iOS devices.
@supports (-webkit-touch-callout: none) {
html {
font: var(--ion-dynamic-font, 16px #{globals.$ion-font-family});
font-family: globals.$ion-font-family;
}
}

body {
@include globals.typography(globals.$ion-body-md-regular);
}
Expand Down
Loading