feat(select-modal): add cancel icon#31089
Merged
OS-susmitabhowmik merged 12 commits intonextfrom Apr 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
ShaneK
approved these changes
Apr 20, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! I had one minor suggestion/comment, but it's not blocking, so approving. Awesome work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Currently the select modal only accepts a string for the
Cancelaction.What is the new behavior?
This PR adds a boolean prop,
cancelIconto theIonSelectmodal which defaults to false. When thecancelIconprop is true, anXicon is added in place of theCanceltext.Does this introduce a breaking change?
Other information
Preview Links: