Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
Apr 24, 2026
| testInfo.annotations.push({ | ||
| type: 'issue', | ||
| description: 'https://github.com/ionic-team/ionic-framework/issues/30900', | ||
| description: 'https://github.com/ionic-team/ionic-framework/issues/31015', |
Contributor
There was a problem hiding this comment.
Why was the issue changed?
| } | ||
|
|
||
| /** | ||
| * Sets --ion-content-safe-area-padding-bottom on the given ion-content |
Contributor
There was a problem hiding this comment.
Correct me if I'm wrong but it seems that --ion-content-safe-area-padding-bottom is a a new variable to the project? If that's the case, can we comment that it's meant for internal usages and when to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31015
What is the current behavior?
Fullscreen modals without an
ion-footersetheightandpadding-bottomon.modal-wrapperto reserve space for the bottom safe-area. Becauseion-content's background does not extend into that wrapper padding, a visible gap appears between the content and the bottom edge of the modal.Separately, modals that declare custom
--widthand--heighton phone viewports flash inherited safe-area values while animating in, then snap to0pxonce the post-animation position correction runs.What is the new behavior?
Bottom safe-area compensation now happens inside
ion-contentinstead of on the wrapper, so the modal background stays edge-to-edge.--ion-content-safe-area-padding-bottomCSS property is added to.inner-scroll'spadding-bottomcalc.modal.tsxsets that property onion-contentfor fullscreen modals without a footer, and clears it on resize and dismiss.heightorpadding-bottominline styles written to it.hasCustomModalDimensions()helper detects modals that override both--widthand--heightto non-fullscreen values. These are zeroed from the initial safe-area prediction so there is no flash before the post-animation correction.findContentAndFooter()andapplyFullscreenSafeAreaTo()helpers so the resize handler and initial apply share the same lookup..inner-scrollpadding including safe-area, and custom-dimension modals starting at zero.Does this introduce a breaking change?
Other information
--ion-content-safe-area-padding-bottomis an internal property. It is additive with the existing--padding-bottomconsumers can set, and it only takes effect whenmodal.tsxwrites it on fullscreen modals without a footer.Example pages:
Example iOS card modal safe-area:
Dev Build: