Merge pull request #300 from Thorium/fsc-update

FSC and FSharp.Core update

Author: nojaf

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.37.0] - 2026-06-04
+
+### Changed
+
+- [Updated FSharp.Core to 10.1 and FSC to 43.12](https://github.com/ionide/FSharp.Analyzers.SDK/pull/300) (thanks @Thorium!)
+
 ## [0.36.0] - 2026-02-02
 
 ### Added

Directory.Packages.props

@@ -6,8 +6,8 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="CliWrap" Version="3.10.0" />
-    <PackageVersion Include="FSharp.Core" Version="[10.0.101]" />
-    <PackageVersion Include="FSharp.Compiler.Service" Version="[43.10.101]" />
+    <PackageVersion Include="FSharp.Core" Version="[10.1.201]" />
+    <PackageVersion Include="FSharp.Compiler.Service" Version="43.12.201" />
     <PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.3.0" PrivateAssets="all" />
     <PackageVersion Include="McMaster.NETCore.Plugins" Version="2.0.0" />
     <PackageVersion Include="Argu" Version="6.2.5" />

src/FSharp.Analyzers.SDK/ASTCollecting.fs

@@ -425,22 +425,23 @@ module ASTCollecting =
             | SynExpr.TypeApp(expr = e; typeArgs = tys) ->
                 List.iter (walkType nextPath) tys
                 walkExpr nextPath e
-            | SynExpr.LetOrUse(isBang = false; bindings = bindings; body = e; range = _) ->
-                List.iter (walkBinding nextPath) bindings
-                walkExpr nextPath e
-            | SynExpr.LetOrUse(isBang = true; bindings = bindings; body = e2; range = _) ->
-                match bindings with
-                | SynBinding(headPat = pat; expr = e1) :: andBangs ->
-                    walkPat nextPath pat
-                    walkExpr nextPath e1
-
-                    for SynBinding(headPat = pat; expr = body) in andBangs do
+            | SynExpr.LetOrUse synLetOrUse ->
+                if synLetOrUse.IsBang then
+                    // let! ... and! ... bindings in a computation expression
+                    match synLetOrUse.Bindings with
+                    | SynBinding(headPat = pat; expr = e1) :: andBangs ->
                         walkPat nextPath pat
-                        walkExpr nextPath body
+                        walkExpr nextPath e1
 
-                | [] -> // error case
+                        for SynBinding(headPat = pat; expr = body) in andBangs do
+                            walkPat nextPath pat
+                            walkExpr nextPath body
 
-                walkExpr nextPath e2
+                    | [] -> () // error case
+                else
+                    List.iter (walkBinding nextPath) synLetOrUse.Bindings
+
+                walkExpr nextPath synLetOrUse.Body
 
             | SynExpr.TryWith(tryExpr = e; withCases = clauses; range = _) ->
                 List.iter (walkClause nextPath) clauses