[Repo Assist] fix: thread document version through PublishDiagnosticsParams (#1526)

* fix: thread document version through PublishDiagnosticsParams

The LSP spec allows PublishDiagnosticsParams to include the document
version for which diagnostics were computed. Clients can use this to
discard stale diagnostics when the user has already made further edits.

Previously the version was always None (a TODO existed noting this gap).
This change:
- Updates DiagnosticCollection.send to compute the max version across
  all diagnostic sources for a given URI and pass it to sendDiagnostics
- Updates sendDiagnostics to accept and forward the version
- Removes the TODO comment

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger checks

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: github-actions[bot]

src/FsAutoComplete/LspServers/AdaptiveServerState.fs

@@ -365,13 +365,12 @@ type AdaptiveState
         FSIRefs.TFM.NetFx)
 
 
-  let sendDiagnostics (uri: DocumentUri) (diags: Diagnostic[]) =
+  let sendDiagnostics (uri: DocumentUri) (version: int option) (diags: Diagnostic[]) =
     logger.info (Log.setMessageI $"SendDiag for {uri:file}: {diags.Length:diags} entries")
 
-    // TODO: providing version would be very useful
     { Uri = uri
       Diagnostics = diags
-      Version = None }
+      Version = version }
     |> lspClient.TextDocumentPublishDiagnostics
 
 

src/FsAutoComplete/LspServers/Common.fs

@@ -55,9 +55,17 @@ type DiagnosticMessage =
   | Clear of source: string
 
 /// a type that handles bookkeeping for sending file diagnostics.  It will debounce calls and handle sending diagnostics via the configured function when safe
-type DiagnosticCollection(sendDiagnostics: DocumentUri -> Diagnostic[] -> Async<unit>) =
+type DiagnosticCollection(sendDiagnostics: DocumentUri -> int option -> Diagnostic[] -> Async<unit>) =
   let send uri (diags: Map<string, Version * Diagnostic[]>) =
-    Map.toArray diags |> Array.collect (snd >> snd) |> sendDiagnostics uri
+    let allDiags = Map.toArray diags |> Array.collect (snd >> snd)
+
+    let maxVersion =
+      if Map.isEmpty diags then
+        None
+      else
+        Map.toArray diags |> Array.map (snd >> fst) |> Array.max |> Some
+
+    sendDiagnostics uri maxVersion allDiags
 
   let agents =
     System.Collections.Concurrent.ConcurrentDictionary<
@@ -134,7 +142,7 @@ type DiagnosticCollection(sendDiagnostics: DocumentUri -> Diagnostic[] -> Async<
   member x.ClearFor(fileUri: DocumentUri) =
     if x.ClientSupportsDiagnostics then
       removeAgent fileUri
-      sendDiagnostics fileUri [||] |> Async.Start
+      sendDiagnostics fileUri None [||] |> Async.Start
 
   member x.ClearFor(fileUri: DocumentUri, kind: string) =
     if x.ClientSupportsDiagnostics then