refactor: remove 'get' prefix from method names to follow Go conventions

This commit refactors method names to follow Go naming conventions by
removing the 'get' prefix from exported methods. In Go, getters should
not have a 'get' prefix as it's considered redundant.

Changes:
- Renamed getLAN() to lan() in network.go
- Renamed getServerNICID() to serverNICID() in network.go
- Updated all call sites in network.go, ipblock.go, and server.go
- Updated corresponding test methods in network_test.go

This improves code consistency and follows Go best practices for
method naming.

Author: schegi

internal/service/cloud/ipblock.go

@@ -199,7 +199,7 @@ func (s *Service) ReconcileFailoverIPBlockDeletion(ctx context.Context, ms *scop
 	}
 
 	// Check if IPBlock is still being used
-	lan, err := s.getLAN(ctx, ms)
+	lan, err := s.lan(ctx, ms)
 	if err != nil {
 		return false, err
 	}

internal/service/cloud/network.go

@@ -69,7 +69,7 @@ func (s *Service) ReconcileLAN(ctx context.Context, ms *scope.Machine) (requeue
 	}
 	defer ms.Locker.Unlock(lockKey)
 
-	lan, request, err := scopedFindResource(ctx, ms, s.getLAN, s.getLatestLANCreationRequest)
+	lan, request, err := scopedFindResource(ctx, ms, s.lan, s.getLatestLANCreationRequest)
 	if err != nil {
 		return false, err
 	}
@@ -109,7 +109,7 @@ func (s *Service) ReconcileLANDeletion(ctx context.Context, ms *scope.Machine) (
 	defer ms.Locker.Unlock(lockKey)
 
 	// Try to retrieve the cluster LAN or even check if it's currently still being created.
-	lan, request, err := scopedFindResource(ctx, ms, s.getLAN, s.getLatestLANCreationRequest)
+	lan, request, err := scopedFindResource(ctx, ms, s.lan, s.getLatestLANCreationRequest)
 	if err != nil {
 		return false, err
 	}
@@ -146,8 +146,8 @@ func (s *Service) ReconcileLANDeletion(ctx context.Context, ms *scope.Machine) (
 	return err == nil, err
 }
 
-// getLAN tries to retrieve the cluster-related LAN in the data center.
-func (s *Service) getLAN(ctx context.Context, ms *scope.Machine) (*sdk.Lan, error) {
+// lan tries to retrieve the cluster-related LAN in the data center.
+func (s *Service) lan(ctx context.Context, ms *scope.Machine) (*sdk.Lan, error) {
 	depth := int32(2) // for listing the LANs with their number of NICs
 
 	// check if the LAN exists
@@ -410,7 +410,7 @@ func (s *Service) swapNICInFailoverGroup(
 	matchLabels client.MatchingLabels,
 ) (requeue bool, err error) {
 	log := s.logger.WithName("swapNICInFailoverGroup")
-	nicID, err := s.getServerNICID(ctx, ms)
+	nicID, err := s.serverNICID(ctx, ms)
 	if err != nil {
 		return false, err
 	}
@@ -470,16 +470,16 @@ func (s *Service) swapNICInFailoverGroup(
 }
 
 func (s *Service) ensureFailoverDeletion(ctx context.Context, ms *scope.Machine) (requeue bool, err error) {
-	nicID, err := s.getServerNICID(ctx, ms)
+	nicID, err := s.serverNICID(ctx, ms)
 	if err != nil || nicID == "" {
 		return false, err
 	}
 
 	return s.removeNICFromFailoverGroup(ctx, ms, nicID)
 }
 
-func (s *Service) getServerNICID(ctx context.Context, ms *scope.Machine) (string, error) {
-	log := s.logger.WithName("getServerNICID")
+func (s *Service) serverNICID(ctx context.Context, ms *scope.Machine) (string, error) {
+	log := s.logger.WithName("serverNICID")
 	server, err := s.getServer(ctx, ms)
 	if err != nil {
 		if isNotFound(err) {
@@ -611,7 +611,7 @@ func (s *Service) retrieveLANFailoverConfig(
 ) (requeue bool, err error) {
 	log := s.logger.WithName("retrieveLANFailoverConfig")
 
-	gotLAN, err := s.getLAN(ctx, ms)
+	gotLAN, err := s.lan(ctx, ms)
 	if err != nil {
 		return true, err
 	}

internal/service/cloud/network_test.go

@@ -86,15 +86,15 @@ func (s *lanSuite) TestNetworkDeleteLANSuccessful() {
 func (s *lanSuite) TestNetworkGetLANSuccessful() {
 	lan := s.exampleLAN()
 	s.mockListLANsCall().Return(&sdk.Lans{Items: &[]sdk.Lan{lan}}, nil).Once()
-	foundLAN, err := s.service.getLAN(s.ctx, s.machineScope)
+	foundLAN, err := s.service.lan(s.ctx, s.machineScope)
 	s.NoError(err)
 	s.NotNil(foundLAN)
 	s.Equal(lan, *foundLAN)
 }
 
 func (s *lanSuite) TestNetworkGetLANNotFound() {
 	s.mockListLANsCall().Return(&sdk.Lans{Items: &[]sdk.Lan{}}, nil).Once()
-	lan, err := s.service.getLAN(s.ctx, s.machineScope)
+	lan, err := s.service.lan(s.ctx, s.machineScope)
 	s.NoError(err)
 	s.Nil(lan)
 }
@@ -104,7 +104,7 @@ func (s *lanSuite) TestNetworkGetLAN_ExistingLAN() {
 	s.mockListLANsCall().Return(&sdk.Lans{Items: &[]sdk.Lan{lan}}, nil).Once()
 
 	s.machineScope.IonosMachine.Spec.NetworkID = ptr.To("42")
-	foundLAN, err := s.service.getLAN(s.ctx, s.machineScope)
+	foundLAN, err := s.service.lan(s.ctx, s.machineScope)
 	s.NoError(err)
 	s.NotNil(foundLAN)
 	s.Equal(lan, *foundLAN)
@@ -115,14 +115,14 @@ func (s *lanSuite) TestNetworkGetLAN_LANIDNotFound() {
 	s.mockListLANsCall().Return(&sdk.Lans{Items: &[]sdk.Lan{lan}}, nil).Once()
 
 	s.machineScope.IonosMachine.Spec.NetworkID = ptr.To("2")
-	foundLAN, err := s.service.getLAN(s.ctx, s.machineScope)
+	foundLAN, err := s.service.lan(s.ctx, s.machineScope)
 	s.EqualError(err, "LAN with ID 2 not found")
 	s.Nil(foundLAN)
 }
 
 func (s *lanSuite) TestNetworkGetLANErrorNotUnique() {
 	s.mockListLANsCall().Return(&sdk.Lans{Items: &[]sdk.Lan{s.exampleLAN(), s.exampleLAN()}}, nil).Once()
-	lan, err := s.service.getLAN(s.ctx, s.machineScope)
+	lan, err := s.service.lan(s.ctx, s.machineScope)
 	s.Error(err)
 	s.Nil(lan)
 }

internal/service/cloud/server.go

@@ -318,7 +318,7 @@ func (s *Service) createServer(ctx context.Context, secret *corev1.Secret, ms *s
 		return errors.New("unable to obtain bootstrap data from secret")
 	}
 
-	lan, err := s.getLAN(ctx, ms)
+	lan, err := s.lan(ctx, ms)
 	if err != nil {
 		return err
 	}