feat(api): remove deprecated FailureReason/FailureMessage fields#359
Draft
schegi wants to merge 4 commits intofeat/upgrade-capi-v1.10.10from
Draft
feat(api): remove deprecated FailureReason/FailureMessage fields#359schegi wants to merge 4 commits intofeat/upgrade-capi-v1.10.10from
schegi wants to merge 4 commits intofeat/upgrade-capi-v1.10.10from
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Also removes the HasFailed guard in the machine controller reconciler, since the underlying FailureReason/FailureMessage fields no longer exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Also removes the SA1019 staticcheck exclusion for the now-unused sigs.k8s.io/cluster-api/errors package from .golangci.yml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailureReasonandFailureMessagefields fromIonosCloudMachineStatusHasFailed()method fromscope/machine.goand its usage in the machine controllersigs.k8s.io/cluster-api/errorsimport (deprecated since CAPI v1.8)Context
The
sigs.k8s.io/cluster-api/errorspackage was deprecated in CAPI v1.8 and the v1.8-to-v1.9 migration guide recommends removal.Test plan
make unit-testpassesmake integration-testpasses (90/90 specs)make lintpassesmake verifypassesMerge
Merge after #358 (CAPI v1.10.10 upgrade).
🤖 Generated with Claude Code