Skip to content

Commit 3ec4f33

Browse files
wikkykclaude
andcommitted
ci(e2e,release): harden shell expansion
Replace ${{ env.* }} expression interpolation with quoted shell variable expansion to prevent potential command injection via environment variables. Co-authored-by: Claude <noreply@anthropic.com>
1 parent b85d788 commit 3ec4f33

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
run: echo 'SKIP_E2E=""' >> "$GITHUB_ENV"
4444

4545
- name: Run e2e tests
46-
run: "make test-e2e GINKGO_SKIP=${{ env.SKIP_E2E }}"
46+
run: make test-e2e "GINKGO_SKIP=$SKIP_E2E"
4747

4848
- name: Upload artifacts
4949
uses: actions/upload-artifact@v7

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
go-version-file: go.mod
2727
- name: generate release artifacts
2828
run: |
29-
make release-manifests RELEASE_VERSION=${{ env.RELEASE_TAG }}
29+
make release-manifests "RELEASE_VERSION=$RELEASE_TAG"
3030
- name: generate release templates
3131
run: |
3232
make release-templates

0 commit comments

Comments
 (0)