fixup! fix: use distinct condition reason for credentials secret errors

keep ProxmoxUnreachableReason with original value; use for non-NotFound errors

Restore ProxmoxUnreachableReason as its own constant with the original
"ProxmoxUnreachable" string value (not a deprecated alias). Use it in
reconcileNormalCredentialsSecret for non-NotFound errors (RBAC, network,
patch conflicts). CredentialsNotFound is reserved for actual missing
secrets.

Co-authored-by: Claude <noreply@anthropic.com>

Author: wikkyk

api/v1alpha2/conditions_consts.go

@@ -27,15 +27,15 @@ const (
 	// underlying Proxmox infrastructure used by the ProxmoxCluster.
 	ProxmoxClusterProxmoxAvailableCondition = "ProxmoxAvailable"
 
+	// ProxmoxClusterProxmoxAvailableProxmoxUnreachableReason documents a controller
+	// detecting issues with Proxmox reachability.
+	ProxmoxClusterProxmoxAvailableProxmoxUnreachableReason = "ProxmoxUnreachable"
+
 	// ProxmoxClusterProxmoxAvailableCredentialsNotFoundReason documents a controller
 	// detecting that credentials are unavailable because spec.credentialsRef is
 	// not set or the referenced credentials secret was not found.
 	ProxmoxClusterProxmoxAvailableCredentialsNotFoundReason = "CredentialsNotFound"
 
-	// Deprecated: use ProxmoxClusterProxmoxAvailableCredentialsNotFoundReason instead.
-	// ProxmoxClusterProxmoxAvailableProxmoxUnreachableReason is kept as an alias for
-	// backwards compatibility with downstream consumers of the v1alpha2 Go API.
-	ProxmoxClusterProxmoxAvailableProxmoxUnreachableReason = ProxmoxClusterProxmoxAvailableCredentialsNotFoundReason
 	// ProxmoxClusterProxmoxAvailableMissingControlPlaneEndpointReason documents a
 	// missing Control Plane endpoint when the cluster uses an externally managed
 	// control plane.

internal/controller/proxmoxcluster_controller.go

@@ -216,7 +216,7 @@ func (r *ProxmoxClusterReconciler) reconcileNormal(ctx context.Context, clusterS
 	}
 
 	if err := r.reconcileNormalCredentialsSecret(ctx, clusterScope); err != nil {
-		reason := clusterv1.InternalErrorReason
+		reason := infrav1.ProxmoxClusterProxmoxAvailableProxmoxUnreachableReason
 		if apierrors.IsNotFound(err) {
 			reason = infrav1.ProxmoxClusterProxmoxAvailableCredentialsNotFoundReason
 		}