Fix ProxmoxMachine deletion to wait for stop/destroy tasks#744
Open
Leonorus wants to merge 3 commits intoionos-cloud:mainfrom
Open
Fix ProxmoxMachine deletion to wait for stop/destroy tasks#744Leonorus wants to merge 3 commits intoionos-cloud:mainfrom
Leonorus wants to merge 3 commits intoionos-cloud:mainfrom
Conversation
wikkyk
reviewed
May 6, 2026
wikkyk
reviewed
May 6, 2026
wikkyk
reviewed
May 6, 2026
Co-authored-by: Vic Kerr <w@kerr.sh>
Collaborator
|
Don't worry about the test 'failure' - it's only the sonarqube report step that's failing (I'm working on improving the workflow). |
Collaborator
|
Thanks. I'll let @65278 do another review because he knows that part of the code better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #742