fix: copilot review

Author: avirtopeanu-ionos

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+Versioning follows [SemVer](https://semver.org/). Sections: **Added**, **Changed**, **Deprecated**, **Fixed**, **Removed**, **Known Limitations**, **Dependencies**. Only user-visible changes listed. Older entries may use non-standard section names.
+
+## [v6.10.2] – June 2026
+
+### Added
+- **Regional API list from all locations**: List commands for regional APIs (DNS, Kafka, VPN, DBaaS, Monitoring, Logging, CDN, CertManager) now query all locations by default and display a `Location` column. Use `--location` to filter to a specific location. `-o json` merges items from all locations; `-o api-json` returns an array of per-location responses.
+- **Multi-location tab completion**: Tab completion for regional resource IDs (e.g. `--cluster-id`, `--gateway-id`) now shows resources from all locations with location hints, when `--location` is not set.
+
 ## [v6.10.1] – May 2026
 
 ### Added

internal/client/regional.go

@@ -24,9 +24,14 @@ func NewRegionalConfig(url string) *shared.Configuration {
 
 	// Apply log level (shared.SdkLogLevel is package-level, already set by main client init)
 
-	// Apply query params
+	// Apply query params (mirrors builder.go logic, including deprecated --max-results)
+	limit := viper.GetString(constants.FlagLimit)
+	if argsContainAny([]string{"--" + constants.DeprecatedFlagMaxResults, "-M"}) {
+		limit = viper.GetString(constants.DeprecatedFlagMaxResults)
+	}
+
 	queryParams := map[string]string{
-		"limit":    viper.GetString(constants.FlagLimit),
+		"limit":    limit,
 		"offset":   viper.GetString(constants.FlagOffset),
 		"depth":    viper.GetString(constants.FlagDepth),
 		"order-by": viper.GetString(constants.FlagOrderBy),

internal/core/flag-option.go

@@ -84,11 +84,16 @@ func WithCompletionComplex(
 				}
 
 				var allResults []string
+				mergedDirective := cobra.ShellCompDirectiveNoFileComp
 				for _, loc := range locations {
 					normalizedLoc := strings.ReplaceAll(loc, "/", "-")
 					viper.Set(constants.ArgServerUrl, fmt.Sprintf(baseURL, normalizedLoc))
 
-					results, _ := completionFunc(passedCmd, args, toComplete)
+					results, directive := completionFunc(passedCmd, args, toComplete)
+					if directive == cobra.ShellCompDirectiveError {
+						continue // skip failed locations
+					}
+					mergedDirective &= directive
 					for _, r := range results {
 						if strings.Contains(r, "\t") {
 							allResults = append(allResults, r+" ("+loc+")")
@@ -97,7 +102,7 @@ func WithCompletionComplex(
 						}
 					}
 				}
-				return allResults, cobra.ShellCompDirectiveNoFileComp
+				return allResults, mergedDirective
 			},
 		)
 	}

internal/core/regional_list.go

@@ -3,6 +3,7 @@ package core
 import (
 	"encoding/json"
 	"fmt"
+	"sort"
 	"strings"
 	"sync"
 
@@ -101,19 +102,27 @@ func (c *CommandConfig) ListAllLocations(
 		if len(errCounts) == 1 {
 			return fmt.Errorf("failed to list from all locations: %w", lastErr)
 		}
-		// Multiple distinct errors — join them
+		// Multiple distinct errors — join them (sorted for stable output)
 		var parts []string
 		for msg, locs := range errCounts {
+			sort.Strings(locs)
 			parts = append(parts, fmt.Sprintf("%s: %s", strings.Join(locs, ", "), msg))
 		}
+		sort.Strings(parts)
 		return fmt.Errorf("failed to list from all locations:\n  %s", strings.Join(parts, "\n  "))
 	}
 
-	// Partial failure — warn only for failed locations
+	// Partial failure — warn only for failed locations (sorted for stable output)
 	if len(errCounts) > 0 {
 		stderr := c.Command.Command.ErrOrStderr()
+		var warns []string
 		for msg, locs := range errCounts {
-			fmt.Fprintf(stderr, "WARN: failed to list from %s: %s\n", strings.Join(locs, ", "), msg)
+			sort.Strings(locs)
+			warns = append(warns, fmt.Sprintf("WARN: failed to list from %s: %s", strings.Join(locs, ", "), msg))
+		}
+		sort.Strings(warns)
+		for _, w := range warns {
+			fmt.Fprintln(stderr, w)
 		}
 	}
 
@@ -141,13 +150,14 @@ func (c *CommandConfig) regionalLegacyJSON(results []locResult) error {
 		if r.err != nil {
 			continue
 		}
-		// Marshal/unmarshal to get a generic map, then extract items
 		b, err := json.Marshal(r.data)
 		if err != nil {
+			fmt.Fprintf(c.Command.Command.ErrOrStderr(), "WARN: failed to marshal response from %s: %v\n", r.location, err)
 			continue
 		}
 		var m map[string]any
 		if err := json.Unmarshal(b, &m); err != nil {
+			fmt.Fprintf(c.Command.Command.ErrOrStderr(), "WARN: failed to parse response from %s: %v\n", r.location, err)
 			continue
 		}
 		if items, ok := m["items"].([]any); ok {

internal/printer/table/table.go

@@ -169,12 +169,6 @@ func (t *Table) AppendRow(row map[string]any) {
 	t.rows = append(t.rows, row)
 }
 
-// SetRaw replaces the raw source data used for JSON output modes.
-// Used by ListAllLocations to set the merged array of per-location responses.
-func (t *Table) SetRaw(data any) {
-	t.raw = data
-}
-
 // SetCell sets a value for a specific column in a specific row.
 // Useful for post-extraction adjustments.
 func (t *Table) SetCell(row int, col string, value any) {