Feat: object storage bucket, policy, object, acl, version crud#659
Merged
avirtopeanu-ionos merged 51 commits intomasterfrom May 7, 2026
Merged
Feat: object storage bucket, policy, object, acl, version crud#659avirtopeanu-ionos merged 51 commits intomasterfrom
avirtopeanu-ionos merged 51 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Object Storage bucket CRUD support to ionosctl, including a dedicated S3 client initializer, CLI commands, docs, and Bats e2e coverage.
Changes:
- Add
object-storage bucketsubcommands (create,get,delete) and register them in the root CLI. - Introduce an Object Storage (S3) client helper and required SDK dependency.
- Add generated command documentation and Bats e2e tests for bucket flows.
Reviewed changes
Copilot reviewed 15 out of 141 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/bats/object-storage/object-storage.bats | Adds e2e Bats tests for bucket create/get/delete and error cases |
| internal/constants/constants.go | Adds constants for object storage flags/env vars |
| internal/client/s3client.go | Adds S3/Object Storage client initialization with env/config credential resolution |
| go.mod | Adds objectstorage SDK dependency |
| docs/summary.md | Adds docs navigation entries for object storage bucket commands |
| docs/subcommands/Compute Engine/object/storage/bucket/create.md | Adds docs page for object-storage bucket create |
| docs/subcommands/Compute Engine/object/storage/bucket/get.md | Adds docs page for object-storage bucket get |
| docs/subcommands/Compute Engine/object/storage/bucket/delete.md | Adds docs page for object-storage bucket delete |
| commands/root.go | Registers the new object-storage command |
| commands/object-storage/object_storage.go | Adds object-storage root command |
| commands/object-storage/bucket/bucket.go | Adds bucket parent command and shared output columns |
| commands/object-storage/bucket/create.go | Implements bucket creation |
| commands/object-storage/bucket/get.go | Implements bucket lookup and output formatting |
| commands/object-storage/bucket/delete.go | Implements bucket deletion with confirmation |
| CLAUDE.md | Adds repository guidance for Claude Code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 150 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 201 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 201 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristiGuranIonos
changed the title
glimberea
requested review from
a team,
adeatcu-ionos,
avirtopeanu-ionos,
cavramoniu-ionos,
cbeti-ionos,
glimberea,
mimihalescu and
rmocanu-ionos
and removed request for
a team
|
avirtopeanu-ionos
force-pushed
the
feat/object-storage-bucket-crud
branch
from
d764ff1 to
5136615
Compare
* add bucket policy command tree * add s3 creds in workflow --------- Co-authored-by: Gabriela Limberea <glimberea@ionos.com>
Co-authored-by: Gabriela Limberea <glimberea@ionos.com>
Co-authored-by: Gabriela Limberea <glimberea@ionos.com>
…instead of region flag
…ct-lock, object retention and legal hold
…bucket related commands under bucket, object related commands under object
avirtopeanu-ionos
force-pushed
the
feat/object-storage-bucket-crud
branch
from
b1e4562 to
a19b617
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ionosctl object-storage command tree for IONOS S3-compatible Object Storage
Also adds S3 credential resolution with provenance display (env vars, config file)