Skip to content

Commit f9ebc1b

Browse files
author
Alexandru Toma
committed
fix tests to pass when lan is not public (to attach pcc)
1 parent d65b3d1 commit f9ebc1b

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2504,7 +2504,7 @@ client.update_k8s_cluster_nodepool(
25042504
'dayOfTheWeek': "Monday",
25052505
'time': '17:00:00'},
25062506
auto_scaling={'minNodeCount': 2, 'maxNodeCount': 3},
2507-
lan_ids=[2,3]
2507+
lan_ids=[2, 3]
25082508
)
25092509
```
25102510
---

tests/helpers/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def resource():
119119
'lan': {
120120
# REST API converts names to lowercase.
121121
'name': 'python sdk test',
122-
'public': True,
122+
'public': False,
123123
},
124124
'ipblock': {
125125
# REST API converts names to lowercase.

tests/test_lan.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,15 @@ def test_list_lans(self):
9090
self.assertEqual(lans['items'][0]['type'], 'lan')
9191
self.assertIn(lans['items'][0]['id'], ('1', '2', '3'))
9292
self.assertEqual(lans['items'][0]['properties']['name'], self.resource['lan']['name'])
93-
self.assertTrue(lans['items'][0]['properties']['public'], self.resource['lan']['public'])
93+
self.assertEqual(lans['items'][0]['properties']['public'], self.resource['lan']['public'])
9494

9595
def test_get_lan(self):
9696
lan = self.client.get_lan(datacenter_id=self.datacenter['id'], lan_id=self.lan['id'])
9797

9898
self.assertEqual(lan['type'], 'lan')
9999
self.assertEqual(lan['id'], self.lan['id'])
100100
self.assertEqual(lan['properties']['name'], self.resource['lan']['name'])
101-
self.assertTrue(lan['properties']['public'], self.resource['lan']['public'])
101+
self.assertEqual(lan['properties']['public'], self.resource['lan']['public'])
102102

103103
def test_remove_lan(self):
104104
lan = self.client.create_lan(
@@ -153,7 +153,7 @@ def test_create_complex_lan(self):
153153

154154
self.assertEqual(response['type'], 'lan')
155155
self.assertEqual(response['properties']['name'], self.resource['lan']['name'])
156-
self.assertTrue(response['properties']['public'])
156+
self.assertFalse(response['properties']['public'])
157157

158158
def test_get_lan_members(self):
159159
members = self.client.get_lan_members(

0 commit comments

Comments
 (0)