Reduce viewer idle cpu#753
Merged
Merged
Conversation
PyrenderViewer and TrimeshSceneViewer re-rendered the scene on every refresh tick (e.g. 30 times per second) even when nothing had changed, keeping the CPU busy on a fully static view. Skip rendering entirely when self._redraw is False. Also force a redraw in TrimeshSceneViewer.save_image so the captured frame is freshly rendered rather than a potentially stale buffer.
The default was lowered to 1Hz in #239 because rendering ran on every refresh tick, pushing idle CPU usage over 300%. Now that rendering is skipped when nothing changed, 30Hz no longer causes that, so restore the original 30Hz default for smooth interaction out of the box.
Reflect the new 1/30 default and note that the viewer only re-renders when the scene changes, so 30Hz no longer keeps the CPU busy on a static view.
Contributor
|
I tested this change by sending a random With |
Contributor
|
This works well. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip rendering in viewers when nothing changed
PyrenderViewer and TrimeshSceneViewer re-rendered the scene on every
refresh tick (e.g. 30 times per second) even when nothing had changed,
keeping the CPU busy on a fully static view. Skip rendering entirely
when self._redraw is False.
Also force a redraw in TrimeshSceneViewer.save_image so the captured
frame is freshly rendered rather than a potentially stale buffer.
cc: @708yamaguchi @nakane11