chore(starfish-core): fix clippy lints surfaced by ci-clippy

- Gate `DagState::new` behind `#[cfg(test)]` (production uses
  `new_with_misbehavior_store` to share the misbehavior store).
- Drop the unused test-only `MisbehaviorStore::dummy_for_test` and
  `DagState::evicted_rounds` helpers.
- Remove redundant `use bcs;` in `scoring_metrics_store::tests`.
- Use `BTreeMap::keys()` instead of `iter().map(|(k, _)| ..)` in
  DagState's flush trace log.
- Drop redundant clones at `DagState::new` / `RegularCommitSyncer::new`
  call sites where the source values are dropped without further use.

Author: piotrm50

crates/starfish/core/src/commit_syncer/regular.rs

@@ -1020,7 +1020,7 @@ mod tests {
             commit_consumer_monitor.clone(),
             network_client,
             block_verifier,
-            dag_state.clone(),
+            dag_state,
             header_synchronizer,
             Arc::new(MisbehaviorStore::new(4)),
             None,

crates/starfish/core/src/dag_state.rs

@@ -236,7 +236,11 @@ pub(crate) struct DagState {
 }
 
 impl DagState {
-    /// Initializes DagState from storage.
+    /// Initializes DagState from storage with a freshly constructed
+    /// `MisbehaviorStore`. Production code uses `new_with_misbehavior_store`
+    /// to share the store with other components; this constructor exists
+    /// for tests that don't need the shared instance.
+    #[cfg(test)]
     pub(crate) fn new(context: Arc<Context>, store: Arc<dyn Store>) -> Self {
         let misbehavior_store = Arc::new(MisbehaviorStore::new(context.committee.size()));
         Self::new_with_misbehavior_store(context, store, misbehavior_store)
@@ -2504,11 +2508,6 @@ impl DagState {
     pub(crate) fn misbehavior_store(&self) -> &MisbehaviorStore {
         &self.misbehavior_store
     }
-
-    #[cfg(test)]
-    pub(crate) fn evicted_rounds(&self) -> Vec<Round> {
-        self.evicted_rounds.clone()
-    }
 }
 #[cfg(test)]
 mod test {

crates/starfish/core/src/scoring_metrics_store.rs

@@ -481,10 +481,6 @@ pub(crate) struct MisbehaviorCountsV1 {
 
 #[cfg(test)]
 impl MisbehaviorStore {
-    pub(crate) fn dummy_for_test(committee_size: usize) -> Self {
-        Self::new(committee_size)
-    }
-
     pub(crate) fn persisted_missing_proposals(&self) -> Vec<u64> {
         self.persisted.collect(|c| c.missing_proposals)
     }
@@ -523,7 +519,6 @@ impl MisbehaviorCounts {
 mod tests {
     use std::sync::Arc;
 
-    use bcs;
     use starfish_config::Parameters;
 
     use super::*;
@@ -741,7 +736,7 @@ mod tests {
         let persisted_missing_before = scoring.persisted_missing_proposals();
         let in_memory_missing_before_drop = scoring.in_memory_missing_proposals();
         drop(dag_state);
-        let mut dag_state = DagState::new(context.clone(), store.clone());
+        let mut dag_state = DagState::new(context, store);
 
         // Persisted metrics should be restored, and in-memory recomputed from
         // the cached block refs loaded during recovery.
@@ -811,7 +806,7 @@ mod tests {
         drop(dag_state);
 
         // Recover from storage and flush again without new blocks
-        let mut dag_state = DagState::new(context.clone(), store.clone());
+        let mut dag_state = DagState::new(context, store);
         dag_state.flush();
 
         // Persisted counts must NOT have doubled