feat: only the sponsor MoveAuthenticator should be executed on the pre-consensus phase for a sponsored transaction#11508
Merged
valeriyr merged 3 commits intoMay 20, 2026
Conversation
iota-ci
added
sc-platform
valeriyr
changed the title
miker83z
reviewed
May 12, 2026
| } | ||
|
|
||
| pub fn digest(&self) -> GenericSignatureDigest { | ||
| GenericSignatureDigest::new(default_hash(self)) |
Contributor
There was a problem hiding this comment.
How can we make sure that this and MoveAuthenticator::digest() will always return the same value, even if we modify the implementation of one of the two?
Contributor
Author
There was a problem hiding this comment.
GenericSignatureDigest was removed; digests for authentication are calculated in the following function:
iota/crates/iota-types/src/transaction.rs
Line 2122 in 9104ec6
valeriyr
force-pushed
the
vm-lang/11262-sponsor-move-auth-only-on-preconsensus
branch
8 times, most recently
from
6ee4fa6 to
fa9a71b
Compare
lzpap
reviewed
May 15, 2026
valeriyr
commented
May 15, 2026
Comment on lines
-6366
to
+6372
| .read_api() | ||
| .get_owned_objects(publisher, None, None, None) | ||
| .coin_read_api() | ||
| .get_coins(publisher, None, None, None) | ||
| .await? | ||
| .data | ||
| .first() | ||
| .unwrap() | ||
| .object() | ||
| .unwrap() | ||
| .object_id; | ||
| .coin_object_id; |
Contributor
Author
There was a problem hiding this comment.
Used coin_read_api to filter for Coin objects only; get_owned_objects
returns all owned objects (including non-coin ones like UpgradeCap) and the
ordering may place non-coin objects first.
Thoralf-M
reviewed
May 18, 2026
valeriyr
force-pushed
the
vm-lang/11262-sponsor-move-auth-only-on-preconsensus
branch
from
c7aa4e1 to
ed823a3
Compare
Thoralf-M
approved these changes
May 19, 2026
Member
Thoralf-M
left a comment
Thoralf-M
left a comment
There was a problem hiding this comment.
Approving the changes in iota-types
…nsus phase refactor: remove GenericSignatureDigest feat: implement tests fix: make CI happy fix(iota): gas coins resolving in `setup_move_authenticator_account` fix(iota-e2e-tests): disable pre_consensus_sponsor_only_move_authentication for tests with disabled AA sponsorship fix(iota-protocol-config): move pre_consensus_sponsor_only_move_authentication to the protocol version 27 feat: improve tests
valeriyr
force-pushed
the
vm-lang/11262-sponsor-move-auth-only-on-preconsensus
branch
from
ed823a3 to
008b271
Compare
miker83z
approved these changes
May 19, 2026
kodemartin
approved these changes
May 19, 2026
muXxer
requested changes
May 19, 2026
piotrm50
approved these changes
May 19, 2026
…ntication to the end of the parameters list
valeriyr
force-pushed
the
vm-lang/11262-sponsor-move-auth-only-on-preconsensus
branch
from
d75c94e to
577ca7d
Compare
semenov-vladyslav
approved these changes
May 19, 2026
muXxer
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Only the sponsor MoveAuthenticator should be executed on the pre-consensus phase for a sponsored transaction.
Links to any relevant issues
fixes #11262
Release Notes