Docs: Modernize installation instructions#17
Open
Takuto88 wants to merge 4 commits into
Open
Conversation
Running setup.py directly now emits a SetuptoolsDeprecationWarning and is no longer the recommended install path; pip install . uses a standards-based installer instead.
These apt-get python3.x-dev instructions targeted pycrypto, which needed a C toolchain to build from source, and covered Python versions that are now EOL. The current pycryptodome dependency ships prebuilt wheels, so no system headers are required to install.
The key was misspelled ('setup_requies'), so setuptools silently
ignored it as an unknown distribution option. It served no
purpose anyway: pip's default build isolation for legacy
(non-pyproject.toml) projects already provides wheel, so there is
nothing for setup_requires to add.
The dash-separated form is deprecated by setuptools and emits a SetuptoolsDeprecationWarning on every build; the underscore form is the supported spelling.
Takuto88
added a commit
to Takuto88/kiopcgenerator
that referenced
this pull request
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains various improvements (see individual commits for details) but the TL;DR is: The direct call to setup.py is deprecated and should be replaced with
pip install .instead and with the change from PR #16 to pycrytodome the dependency towheeland development headers are no longer needed.