Skip to content

fix(release-check): pass -version to gorelease #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galargh merged 1 commit into from
May 1, 2026
Merged

fix(release-check): pass -version to gorelease #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ jobs:
env:
LANGUAGE: ${{ github.event.pull_request.base.repo.language }}
PREV_TAG: ${{ steps.prev.outputs.tag }}
VERSION: v${{ steps.version.outputs.version }}
# see https://github.com/golang/exp/commits/master/cmd/gorelease
run: |
git config advice.detachedHead false
Expand All @@ -219,7 +220,11 @@ jobs:
echo "\`gorelease\` says:" >> $GITHUB_OUTPUT
echo "\`\`\`" >> $GITHUB_OUTPUT
echo "Run gorelease"
((gorelease -base "$PREV_TAG") 2>&1 || true) | tee -a $GITHUB_OUTPUT
# Pass -version so gorelease uses the working tree as the release candidate.
# Without it, gorelease resolves the candidate via MVS over the module graph,
# which picks the wrong version when a dependency transitively requires an
# older version of the module being released (e.g. boxo -> kad-dht).
((gorelease -base "$PREV_TAG" -version "$VERSION") 2>&1 || true) | tee -a $GITHUB_OUTPUT
echo "\`\`\`" >> $GITHUB_OUTPUT
echo "" >> $GITHUB_OUTPUT
echo "\`gocompat\` says:" >> $GITHUB_OUTPUT
Expand Down
Loading