fix: detect abnormal shutdown and trigger repair on next start#351
Merged
Conversation
This was referenced Apr 21, 2026
gammazero
approved these changes
May 1, 2026
Contributor
gammazero
left a comment
There was a problem hiding this comment.
One question. Otherwise ok to merge.
hsanjuan
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix suggested in #279 (comment)
Problem
A CRDT replica can be left in a silently inconsistent state after an abnormal termination (SIGKILL, OOM, panic without
Close(), power loss).Fix
Persist a single key,
/<namespace>/bs, whose presence at startup means "the previous run did not close cleanly":MarkDirtythe store (so repair runs) and log a warning. Then write the key unconditionally so a crash in this run is caught on the next start.Close(): afterwg.Wait()(so any worker still marking dirty during shutdown has finished), delete the key as the last step.No changes to the walk/merge hot path,
MarkDirty/IsDirtysignatures, orrepairDAGscope.