Skip to content

fix(files): unpin option missing in batch delete #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lidel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(files): unpin option missing in batch delete #2488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/files/FilesPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const FilesPage = ({
doFetchPinningServices, doFilesFetch, doPinsFetch, doFilesSizeGet, doFilesDownloadLink, doFilesDownloadCarLink, doFilesWrite, doAddCarFile, doFilesBulkCidImport, doFilesAddPath, doUpdateHash,
doFilesUpdateSorting, doFilesNavigateTo, doFilesMove, doSetCliOptions, doFetchRemotePins, remotePins, pendingPins, failedPins,
ipfsProvider, ipfsConnected, doFilesMakeDir, doFilesShareLink, doFilesCidProvide, doFilesDelete, doSetPinning, onRemotePinClick, doPublishIpnsKey,
files, filesPathInfo, filesIsFetching, pinningServices, toursEnabled, handleJoyrideCallback, isCliTutorModeEnabled, cliOptions, filesSorting, t
files, pins, filesPathInfo, filesIsFetching, pinningServices, toursEnabled, handleJoyrideCallback, isCliTutorModeEnabled, cliOptions, filesSorting, t
}) => {
const { doExploreUserProvidedPath } = useExplore()
const contextMenuRef = useRef()
Expand Down Expand Up @@ -219,10 +219,10 @@ const FilesPage = ({
.filter(n => n)
.map(file => ({
...file,
pinned: files?.pins?.map(p => p.toString())?.includes(file.cid.toString())
pinned: (pins || []).includes(file.cid.toString())
}))
/* eslint-disable-next-line react-hooks/exhaustive-deps */
, [files?.content, files?.pins, selected])
, [files?.content, pins, selected])

if (!files || files.type === 'file') return null
// if file not found
Expand Down Expand Up @@ -251,7 +251,7 @@ const FilesPage = ({
const commonProps = {
updateSorting: doFilesUpdateSorting,
files: files.content || [],
pins: files.pins || [],
pins: pins || [],
remotePins: remotePins || [],
pendingPins: pendingPins || [],
failedPins: failedPins || [],
Expand Down Expand Up @@ -454,6 +454,7 @@ export default connect(
'selectIpfsProvider',
'selectIpfsConnected',
'selectFiles',
'selectPins',
'selectFilesIsFetching',
'selectRemotePins',
'selectPendingPins',
Expand Down
Loading