simplify tests and do real requests

Author: UmanShahzad

.rubocop.yml

@@ -18,6 +18,9 @@ Metrics/MethodLength:
 Metrics/AbcSize:
     Enabled: false
 
+Metrics/ClassLength:
+    Enabled: false
+
 Lint/DuplicateMethods:
     Enabled: false
 

Gemfile

@@ -8,19 +8,6 @@ group :development do
     gem 'bundler'
     gem 'minitest'
     gem 'minitest-reporters'
-    gem 'minitest-vcr'
-    gem 'rack', '>= 1.5'
     gem 'rake'
     gem 'rubocop'
-    gem 'webmock'
-
-    platforms :mri do
-        # to avoid problems, bring Byebug in on just versions of Ruby under
-        # which it's known to work well
-        if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.0.0')
-            gem 'byebug'
-            gem 'pry'
-            gem 'pry-byebug'
-        end
-    end
 end

lib/ipinfo.rb

@@ -63,18 +63,21 @@ def details(ip_address = nil)
     protected
 
     def request_details(ip_address = nil)
-        unless @cache.contains?(ip_address)
-            response = @httpc.get(escape_path(ip_address))
+        res = @cache.get(ip_address)
+        if res != nil
+            return res
+        end
 
-            if response.status.eql?(429)
-                raise RateLimitError,
-                      RATE_LIMIT_MESSAGE
-            end
+        response = @httpc.get(escape_path(ip_address))
 
-            details = JSON.parse(response.body, symbolize_names: true)
-            @cache.set(ip_address, details)
+        if response.status.eql?(429)
+            raise RateLimitError,
+                  RATE_LIMIT_MESSAGE
         end
-        @cache.get(ip_address)
+
+        details = JSON.parse(response.body, symbolize_names: true)
+        @cache.set(ip_address, details)
+        details
     end
 
     def prepare_http_client(httpc = nil)

lib/ipinfo/response.rb

@@ -11,7 +11,9 @@ def initialize(response)
 
         @all.each do |name, value|
             instance_variable_set("@#{name}", value)
-            self.class.send(:attr_accessor, name)
+
+            c = class << self; self end
+            c.send(:attr_accessor, name)
         end
     end
 end