Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
160 lines (116 loc) · 6.87 KB

CONTRIBUTING.md

File metadata and controls

160 lines (116 loc) · 6.87 KB

Contributing

When contributing to this repository, please first discuss the change you wish to make via Issues.

Please note we have a code of conduct, please follow it in all your interactions with the project.

Development Process

We follow Git Flow for changes to this repository.

GitHub desktop is much easier if you're unfamiliar with using git / GitHub on the command line.

  • Fork this repo to create a copy hosted on your github account. The Fork button is in the top right of the page.
    • If you're a collaborator on the repo you can instead just create a branch.
  • Clone down your copy of this repo onto your local machine: git clone <YOUR GITHUB REPO URL>
  • Navigate to the new directory git created. cd postman-docs
  • Checkout the develop branch. git checkout develop
  • Run npm install to add all dependencies
  • Create a new branch for your work based on develop git checkout -b <YOUR BRANCH NAME> Your branch name should be something descriptive of the changes you wish to make, and can include the issue number this change is associated with. Example: feature/1234-update-mock-api-docs
  • Make your changes. The Learning Center's documentation is built from the .md files in the /src/pages/docs folder of the repo
  • Check your files against our markdown guidelines by running npm run test:mdlint and resolve any errors
  • When you're ready to apply your changes, push your changed files to your forked repo
    • git add <FILENAMES OF CHANGED FILES>
    • git commit -m "<YOUR COMMIT MESSAGE>" Your commit message should be descriptive of the changes you made
    • git push -u origin HEAD This will push your changes to the branch you created on your forked repo
  • Open a Pull Request to the postman-docs repo
    • Navigate to the postman-docs repo
    • Click New pull request
    • Click Compare across forks
    • Select base repository: postmanlabs/postman-docs
    • Select base branch: develop
    • Select head repository: <YOUR FORKED REPOSITORY>
    • Select head branch: <YOUR BRANCH NAME>
    • Click Create pull request

Your pull request will be reviewed and we'll get back to you!

Pull Request Process

When your PR is opened it will run GitHub Actions which will lint the markdown files to ensure that they follow our guidelines.

Upon approval your PR will be merged into develop for further verification and then merged into master upon final approval. Please delete your branch once it's been merged to develop to help maintain a clean repository.

Staff and Repo Collaborators: Please only push to develop when changes are ready to publish. The develop branch is intended only as a last check to see edits live on the web in a production type build environment before publishing—changes shouldn't sit on the develop branch for long before pushing to master.

Adding/Editing Images

If you would like to add, edit or replace images you are welcome to do so. There are two ways in which you can achieve this:

  • You can upload the image to your GitHub Pull-Request and link the image
  • You can host the image and link to your own hosted image

Note:

Images hosted by Postman should always be referenced as follows:

https://assets.postman.com/postman-docs/<filename>.png

Algolia

Please note that Algolia search will not work when running the app locally. If you wish to search when running the app locally, you are welcome to use your own Algolia API keys and index the app in your own Algolia account. You can find an env.example file in the repo that shows you what keys you require to run Algolia search.

Right Sidebar - Recent Blog Posts

The right sidebar has a feature flag for pulling in up to 3 contextual, recent blog posts based on a tag. This functionality and flag can be found in the frontmatter of the doc .md files. It utilizes our webhook and backend-for-frontend (BFF) service to source the latest 100 blog posts from blog.postman.com.

Two example docs using dynamic_blog:

  • /docs/running-collections/intro-to-collection-runs.md
  • /docs/running-collections/scheduling-collection-runs.md

To Use the Dynamic Blog Posts Feature

For internal Postman contributors

You need to get the .env.development file from Marketing Engineering, and place in root of local Learning Center (.gitignore will keep it from getting checked in).

  • If you do not have this file or are an external contributor, the app will still build, but the Recent Blogs section in right sidebar will be hidden / blank (this is expected behavior).
  • .env.development file is for internal use only.

When updating from hardcoded blog links to dynamic:

Open doc file .md that you want to edit right sidebar, and look for contextual_links in frontmatter. Look for presence of existing recent Blogs posts like:

- type: subtitle
    name: "Related Blog Posts"
- type: link
    name: "Check for broken links on your website using a Postman Collection"
    url: "https://blog.postman.com/check-for-broken-links-on-your-website-using-a-postman-collection/"

Replace with:

- type: dynamic_blog
name: "Related Blog Posts"
blog_tag: "PUT_TAG_NAME_HERE"

NOTE: type: link and type: url are being replaced with blog_tag: “PUT_TAG_NAME_HERE”

When adding dynamic links (no blog links currently):

Open doc file .md that you want edit right sidebar, and add:

- type: dynamic_blog
    name: "Related Blog Posts"
    blog_tag: "PUT_TAG_NAME_HERE"

blog_tag is an enum

The list of acceptable values for blog_tag are the slugs for tags in the blog. The blog_tag value is a string and only accepts one tag. To yield contextual posts for your doc page, use one of the following machiine-readbale blog tags in use today:

  • api-development
  • api-network
  • automation
  • aws
  • case-study
  • collections
  • continuous-delivery
  • data
  • developers
  • documentation
  • enterprise-plan
  • graphql
  • integrations
  • monitors
  • newman
  • news
  • openapi
  • postman
  • postman-community
  • public-workspaces
  • rest-api
  • security
  • state-of-the-api
  • testing
  • tutorials
  • visualizer
  • workflow
  • workspaces

NOTE: these tags pull from the latest 100 blog posts. We display up to 3 blog posts for that tag. A return of zero or malformed tag enum will collapse / hide section.

Run checks locally

Before creating a PR we STRONGLY recommend to running the following test locally to check that all changes will pass our linters:

  • npm run test -> runs the Unit testing
  • npm run test:mdlint -> runs the Markdownlinter
  • npm run test:lint -> runs the ESlinter
  • npm run test:url -> checks if acceptable image URL has been added
  • npm run test:update -> updates the test snapshots