tools: Fold evmone-t8n into the evmone CLI as a subcommand (#1551)

Replace the standalone evmone-t8n binary with `evmone t8n`. The
standalone executable is removed.

The command line options are the same, but now parsed by CLI11,
which makes validation strict at parse time:

- --state.reward range-checked via CLI::Range(-1, INT64_MAX); -1
  remains the "emit pre-state only" sentinel.
- --input.alloc/env/txs/blobParams must exist (CLI::ExistingFile);
  previously the standalone binary would open and read an empty/
  failed stream.
- Unknown options now error; previously the hand-rolled if-else
  chain silently ignored them.

Author: chfast

circle.yml

@@ -259,7 +259,7 @@ commands:
         default: ""
       binaries:
         type: string
-        default: evmone evmone-unittests evmone-statetest evmone-blockchaintest evmone-t8n
+        default: evmone evmone-unittests evmone-statetest evmone-blockchaintest
     steps:
       - run:
           name: "Collect coverage data (clang, <<parameters.flags>>)"
@@ -421,14 +421,14 @@ jobs:
           filter: "-for_amsterdam/*:for_bpo2toamsterdamattime15k/*"
       - collect_coverage_clang:
           flags: eest-develop
-          ignore_filename_regex: lib/evmone/(advanced|cpu_check|eof|lru_cache|tracing|vm)|test/(experimental|t8n|unittests|utils)
+          ignore_filename_regex: lib/evmone/(advanced|cpu_check|eof|lru_cache|tracing|vm)|test/(experimental|unittests|utils)
           binaries: evmone-statetest evmone-blockchaintest
       - run_execution_spec_tests:
           release: v5.4.0
           fixtures_suffix: develop
       - collect_coverage_clang:
           flags: eest-stable
-          ignore_filename_regex: lib/evmone/(advanced|cpu_check|eof|lru_cache|tracing|vm)|test/(experimental|t8n|unittests|utils)
+          ignore_filename_regex: lib/evmone/(advanced|cpu_check|eof|lru_cache|tracing|vm)|test/(experimental|unittests|utils)
           binaries: evmone-statetest evmone-blockchaintest
 
   ethereum-tests:

codecov.yml

@@ -23,7 +23,6 @@ component_management:
         - test/eofparse/**
         - test/eoftest/**
         - test/statetest/**
-        - test/t8n/**
         - test/utils/**
     - component_id: tests
       name: tests

test/CMakeLists.txt

@@ -25,10 +25,9 @@ add_subdirectory(integration)
 add_subdirectory(internal_benchmarks)
 add_subdirectory(precompiles_bench)
 add_subdirectory(statetest)
-add_subdirectory(t8n)
 add_subdirectory(unittests)
 
-set(targets evmone-bench evmone-bench-internal evmone-blockchaintest evmone-precompiles-bench evmone-state evmone-statetest evmone-t8n evmone-unittests)
+set(targets evmone-bench evmone-bench-internal evmone-blockchaintest evmone-precompiles-bench evmone-state evmone-statetest evmone-unittests)
 
 if(EVMONE_FUZZING)
     add_subdirectory(fuzzer)

test/integration/t8n/CMakeLists.txt

@@ -2,7 +2,7 @@
 # Copyright 2024 The evmone Authors.
 # SPDX-License-Identifier: Apache-2.0
 
-# Integration tests for evmone-t8n.
+# Integration tests for the `evmone t8n` subcommand.
 
 set(PREFIX ${PREFIX}/t8n)
 
@@ -12,7 +12,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/base_fee
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork London
     --state.reward 0
     --state.chainid 1
@@ -46,7 +46,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/base_fee
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Berlin
     --state.reward 0
     --state.chainid 1
@@ -76,7 +76,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/${TEST_CASE}
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Cancun
     --state.reward 0
     --state.chainid 1
@@ -86,7 +86,6 @@ add_test(
     --output.basedir ${CMAKE_CURRENT_BINARY_DIR}/${TEST_CASE}
     --output.result out.json
     --output.alloc outAlloc.json
-    --output.errorlog error.json
     --opcode.count opcodes.json
 )
 set_tests_properties(${PREFIX}/${TEST_CASE} PROPERTIES FIXTURES_REQUIRED ${TEST_CASE})
@@ -157,7 +156,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/${TEST_CASE}
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Prague
     --state.reward 0
     --state.chainid 1
@@ -192,7 +191,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/${TEST_CASE}
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Osaka
     --state.reward 0
     --state.chainid 1
@@ -226,7 +225,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/cancun_create_tx
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Cancun
     --state.reward 0
     --state.chainid 1
@@ -254,15 +253,27 @@ set_tests_properties(
 )
 
 
-add_test(NAME ${PREFIX}/version COMMAND evmone-t8n --version)
+add_test(NAME ${PREFIX}/version COMMAND evmone-cli --version)
 set_tests_properties(
-    ${PREFIX}/version PROPERTIES PASS_REGULAR_EXPRESSION "evmone-t8n")
+    ${PREFIX}/version PROPERTIES PASS_REGULAR_EXPRESSION "evmone")
 
-add_test(NAME ${PREFIX}/bad_fork COMMAND evmone-t8n --state.fork NoSuchRev)
+add_test(NAME ${PREFIX}/bad_fork COMMAND evmone-cli t8n --state.fork NoSuchRev)
 set_tests_properties(
     ${PREFIX}/bad_fork PROPERTIES PASS_REGULAR_EXPRESSION "unknown revision")
 
 
+# Check if chainid max value is accepted.
+add_test(
+    NAME ${PREFIX}/chainid_hex_max
+    WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/base_fee
+    COMMAND
+    evmone-cli t8n
+    --state.fork Paris
+    --state.chainid 0xffffffffffffffff
+    --input.env env.json
+)
+
+
 # Exercises both --output.body (RLP-encoded transactions) and
 # --state.reward -1 (pre-state-only mode that emits just the state root).
 set(TEST_CASE prague_pre_state_only)
@@ -271,7 +282,7 @@ add_test(
     NAME ${PREFIX}/${TEST_CASE}
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/prague_empty_requests
     COMMAND
-    evmone-t8n
+    evmone-cli t8n
     --state.fork Prague
     --state.reward -1
     --state.chainid 1