Conversation
Reviewer's GuideThis PR refactors the GtkSortTypeFromStr API to use an out-parameter and boolean return, updates its call sites, adds an undefined sanitizer toggle to the Meson build, adjusts application startup initialization, adds a division-by-zero guard in the file transfer model, and invokes startup in the test helper. Sequence diagram for GtkSortTypeFromStr usage in MainWindow::onSortTypesequenceDiagram
participant MainWindow
participant UiModels
MainWindow->>UiModels: GtkSortTypeFromStr(sortType, &sort_type)
alt success
UiModels-->>MainWindow: true, sort_type set
MainWindow->>MainWindow: set sort_type_
else failure
UiModels-->>MainWindow: false
MainWindow->>MainWindow: log warning, return
end
Class diagram for GtkSortTypeFromStr API refactorclassDiagram
class UiModels {
+bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType)
+const char* GtkSortTypeToStr(GtkSortType t)
}
class MainWindow {
-GtkSortType sort_type_
+void LoadConfig()
+void onSortType(GSimpleAction* action, GVariant* value, MainWindow& self)
}
UiModels <.. MainWindow : uses
note for UiModels "GtkSortTypeFromStr now returns bool and uses out-parameter."
Class diagram for TransFileModel division-by-zero guardclassDiagram
class TransFileModel {
+double getProgress() const
-int64_t finishedLength
-int64_t fileLength
}
note for TransFileModel "getProgress now guards against fileLength <= 0."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lidaobing - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Consider validating the outType pointer before dereferencing. (link)
General comments:
- In GtkSortTypeFromStr, add an assertion or null-pointer check for outType before dereferencing to avoid potential segfaults if someone passes nullptr.
- Reordering the creation of ProgramData/UiCoreThread before init_theme and logSystem may introduce startup races—ensure the core thread isn’t accessing uninitialized resources.
- Wrap the
-fsanitize=undefinedflags behind a compiler capability check in meson.build to prevent build failures on toolchains that don’t support undefined behavior sanitizer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In GtkSortTypeFromStr, add an assertion or null-pointer check for outType before dereferencing to avoid potential segfaults if someone passes nullptr.
- Reordering the creation of ProgramData/UiCoreThread before init_theme and logSystem may introduce startup races—ensure the core thread isn’t accessing uninitialized resources.
- Wrap the `-fsanitize=undefined` flags behind a compiler capability check in meson.build to prevent build failures on toolchains that don’t support undefined behavior sanitizer.
## Individual Comments
### Comment 1
<location> `src/iptux/UiModels.cpp:358` </location>
<code_context>
};
-GtkSortType GtkSortTypeFromStr(const std::string& s) {
+bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) {
for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) {
if (s == gtk_sort_type_names[i]) {
</code_context>
<issue_to_address>
Consider validating the outType pointer before dereferencing.
Dereferencing a nullptr outType will cause undefined behavior. Please add a check for nullptr and return false if detected.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) {
for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) {
if (s == gtk_sort_type_names[i]) {
*outType = (GtkSortType)i;
return true;
}
}
return false;
}
=======
bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) {
if (!outType) {
return false;
}
for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) {
if (s == gtk_sort_type_names[i]) {
*outType = (GtkSortType)i;
return true;
}
}
return false;
}
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `src/iptux-core/TransFileModel.cpp:111` </location>
<code_context>
}
double TransFileModel::getProgress() const {
+ if (fileLength <= 0) {
+ return 0.0; // Avoid division by zero
+ }
return percent(finishedLength, fileLength);
</code_context>
<issue_to_address>
Returning 0.0 for non-positive fileLength may mask input errors.
Consider logging a warning if fileLength is negative, as this may signal a logic error.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
358
to
366
| bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) { | ||
| for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) { | ||
| if (s == gtk_sort_type_names[i]) { | ||
| return (GtkSortType)i; | ||
| *outType = (GtkSortType)i; | ||
| return true; | ||
| } | ||
| } | ||
| return GTK_SORT_TYPE_INVALID; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
suggestion (bug_risk): Consider validating the outType pointer before dereferencing.
Dereferencing a nullptr outType will cause undefined behavior. Please add a check for nullptr and return false if detected.
Suggested change
| bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) { | |
| for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) { | |
| if (s == gtk_sort_type_names[i]) { | |
| return (GtkSortType)i; | |
| *outType = (GtkSortType)i; | |
| return true; | |
| } | |
| } | |
| return GTK_SORT_TYPE_INVALID; | |
| return false; | |
| } | |
| bool GtkSortTypeFromStr(const std::string& s, GtkSortType* outType) { | |
| if (!outType) { | |
| return false; | |
| } | |
| for (int i = GTK_SORT_ASCENDING; i <= GTK_SORT_DESCENDING; ++i) { | |
| if (s == gtk_sort_type_names[i]) { | |
| *outType = (GtkSortType)i; | |
| return true; | |
| } | |
| } | |
| return false; | |
| } |
Comment on lines
+111
to
+112
| if (fileLength <= 0) { | ||
| return 0.0; // Avoid division by zero |
There was a problem hiding this comment.
suggestion (bug_risk): Returning 0.0 for non-positive fileLength may mask input errors.
Consider logging a warning if fileLength is negative, as this may signal a logic error.
lidaobing
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 52.42% 52.38% -0.04%
==========================================
Files 64 64
Lines 8603 8599 -4
==========================================
- Hits 4510 4505 -5
- Misses 4093 4094 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor sort type parsing and client startup sequence; add undefined-behavior sanitizer support; guard against zero-length transfers; and ensure application startup is called in tests.
Bug Fixes:
Enhancements:
Build:
Tests: