Skip to content

#705: fix snap build failed#706

Merged
lidaobing merged 1 commit into
mainfrom
bf_705_snap_build_failed
Jan 25, 2026
Merged

#705: fix snap build failed#706
lidaobing merged 1 commit into
mainfrom
bf_705_snap_build_failed

Conversation

@lidaobing

@lidaobing lidaobing commented Jan 25, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Silence deprecation warnings around appindicator initialization to restore compatibility with the snap build.

Bug Fixes:

  • Resolve snap build failures caused by deprecation warnings from appindicator initialization.

Build:

  • Adjust appindicator usage to avoid deprecation-related build failures in snap packaging.

@sourcery-ai

sourcery-ai Bot commented Jan 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Wraps the deprecated app_indicator_new call with deprecation-ignore macros to fix snap build failures while keeping the current indicator implementation unchanged.

File-Level Changes

Change Details Files
Guard the deprecated app_indicator_new usage with deprecation suppression macros to restore snap build compatibility.
  • Instantiate the IptuxAppIndicatorPrivate shared_ptr before indicator setup as before
  • Add a comment explaining app_indicator_new deprecation and the preferred but unstable replacement library
  • Wrap the app_indicator_new call between G_GNUC_BEGIN_IGNORE_DEPRECATIONS and G_GNUC_END_IGNORE_DEPRECATIONS macros to silence deprecation warnings/errors in the snap build
  • Leave subsequent app_indicator_set_status and app_indicator_set_attention_icon_full calls unchanged
src/iptux/AppIndicator.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions

Copy link
Copy Markdown

Test Results

69 tests  ±0   69 ✅ ±0   4s ⏱️ -1s
32 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9e10a5e. ± Comparison against base commit 6ea96a6.

@codecov

codecov Bot commented Jan 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.04%. Comparing base (6ea96a6) to head (9e10a5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   52.00%   52.04%   +0.03%     
==========================================
  Files          64       64              
  Lines        8599     8599              
==========================================
+ Hits         4472     4475       +3     
+ Misses       4127     4124       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lidaobing lidaobing linked an issue Jan 25, 2026 that may be closed by this pull request
@lidaobing lidaobing merged commit 3014351 into main Jan 25, 2026
18 of 20 checks passed
@lidaobing lidaobing deleted the bf_705_snap_build_failed branch January 25, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snap build failed

1 participant