Skip to content

Commit 9970618

Browse files
authored
Fix failing test and update matrix (#1010)
1 parent 03973be commit 9970618

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,18 @@ jobs:
2020
fail-fast: false
2121
matrix:
2222
os: [ubuntu-latest, windows-latest, macos-latest]
23-
python-version: ["3.7", "3.10"]
23+
python-version: ["3.7", "3.11"]
24+
exclude:
25+
- os: macos-latest
26+
python-version: "3.11" # not yet available
2427
include:
2528
- os: windows-latest
2629
python-version: "3.9"
2730
- os: ubuntu-latest
2831
python-version: "pypy-3.7"
29-
- os: ubuntu-latest
30-
python-version: "3.11-dev"
3132
- os: macos-latest
33+
python-version: "3.10"
34+
- os: ubuntu-latest
3235
python-version: "3.8"
3336
steps:
3437
- name: Checkout

ipykernel/tests/test_message_spec.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -509,9 +509,7 @@ def test_connect_request():
509509
flush_channels()
510510
msg = KC.session.msg("connect_request")
511511
KC.shell_channel.send(msg)
512-
return msg["header"]["msg_id"]
513-
514-
msg_id = KC.kernel_info()
512+
msg_id = msg["header"]["msg_id"]
515513
reply = get_reply(KC, msg_id, TIMEOUT)
516514
validate_message(reply, "connect_reply", msg_id)
517515

0 commit comments

Comments
 (0)