Skip to content

Commit a7b4891

Browse files
Carreauianthomas23
authored andcommitted
Don't rerun test with --lf it hides failures. (#1324)
1 parent b4d64a2 commit a7b4891

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,19 @@ jobs:
4646
timeout-minutes: 15
4747
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && !startsWith(matrix.os, 'windows') }}
4848
run: |
49-
hatch run cov:test --cov-fail-under 50 || hatch run test:test --lf
49+
hatch run cov:test --cov-fail-under 50
5050
5151
- name: Run the tests on pypy
5252
timeout-minutes: 15
5353
if: ${{ startsWith( matrix.python-version, 'pypy' ) }}
5454
run: |
55-
hatch run test:nowarn || hatch run test:nowarn --lf
55+
hatch run test:nowarn
5656
5757
- name: Run the tests on Windows
5858
timeout-minutes: 15
5959
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && startsWith(matrix.os, 'windows') }}
6060
run: |
61-
hatch run cov:nowarn || hatch run test:nowarn --lf
61+
hatch run cov:nowarn
6262
6363
- name: Check Launcher
6464
run: |
@@ -141,7 +141,7 @@ jobs:
141141
142142
- name: Run the tests
143143
timeout-minutes: 15
144-
run: pytest -W default -vv || pytest --vv -W default --lf
144+
run: pytest -W default -vv
145145

146146
test_miniumum_versions:
147147
name: Test Minimum Versions
@@ -161,7 +161,7 @@ jobs:
161161
162162
- name: Run the unit tests
163163
run: |
164-
hatch -v run test:nowarn || hatch run test:nowarn --lf
164+
hatch -v run test:nowarn
165165
166166
test_prereleases:
167167
name: Test Prereleases
@@ -176,7 +176,7 @@ jobs:
176176
dependency_type: pre
177177
- name: Run the tests
178178
run: |
179-
hatch run test:nowarn || hatch run test:nowarn --lf
179+
hatch run test:nowarn
180180
181181
make_sdist:
182182
name: Make SDist

.readthedocs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2
33
build:
44
os: ubuntu-22.04
55
tools:
6-
python: "3.11"
6+
python: "3.13"
77

88
sphinx:
99
configuration: docs/conf.py

tests/test_eventloop.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,16 @@ def test_cocoa_loop(kernel):
124124
loop_cocoa(kernel)
125125

126126

127-
@pytest.mark.skipif(
128-
len(qt_guis_avail) == 0, reason="No viable version of PyQt or PySide installed."
129-
)
130-
def test_qt_enable_gui(kernel, capsys):
131-
gui = qt_guis_avail[0]
132-
127+
@pytest.mark.parametrize("gui", qt_guis_avail)
128+
def test_qt_enable_gui(gui, kernel, capsys):
129+
if os.getenv("GITHUB_ACTIONS", None) == "true" and gui == "qt5":
130+
pytest.skip("Qt5 and GitHub action crash CPython")
131+
if gui == "qt6" and sys.version_info < (3, 10):
132+
pytest.skip(
133+
"qt6 fails on 3.9 with AttributeError: module 'PySide6.QtPrintSupport' has no attribute 'QApplication'"
134+
)
135+
if sys.platform == "linux" and gui == "qt6" and os.getenv("GITHUB_ACTIONS", None) == "true":
136+
pytest.skip("qt6 fails on github CI with missing libEGL.so.1")
133137
enable_gui(gui, kernel)
134138

135139
# We store the `QApplication` instance in the kernel.

0 commit comments

Comments
 (0)