address most lint

not translation, yet

Author: minrk

lab/src/clusters.tsx

@@ -282,7 +282,7 @@ export class ClusterManager extends Widget {
    */
   protected onAfterAttach(msg: Message): void {
     super.onAfterAttach(msg);
-    let node = this._clusterListing.node;
+    const node = this._clusterListing.node;
     node.addEventListener("p-dragenter", this);
     node.addEventListener("p-dragleave", this);
     node.addEventListener("p-dragover", this);
@@ -293,7 +293,7 @@ export class ClusterManager extends Widget {
    * Handle `before-detach` messages for the widget.
    */
   protected onBeforeDetach(msg: Message): void {
-    let node = this._clusterListing.node;
+    const node = this._clusterListing.node;
     node.removeEventListener("p-dragenter", this);
     node.removeEventListener("p-dragleave", this);
     node.removeEventListener("p-dragover", this);
@@ -378,13 +378,13 @@ export class ClusterManager extends Widget {
    * Handle the `'mousemove'` event for the widget.
    */
   private _evtMouseMove(event: MouseEvent): void {
-    let data = this._dragData;
+    const data = this._dragData;
     if (!data) {
       return;
     }
     // Check for a drag initialization.
-    let dx = Math.abs(event.clientX - data.pressX);
-    let dy = Math.abs(event.clientY - data.pressY);
+    const dx = Math.abs(event.clientX - data.pressX);
+    const dy = Math.abs(event.clientY - data.pressY);
     if (dx >= DRAG_THRESHOLD || dy >= DRAG_THRESHOLD) {
       event.preventDefault();
       event.stopPropagation();
@@ -641,7 +641,7 @@ export namespace ClusterManager {
  * A React component for a launcher button listing.
  */
 function ClusterListing(props: IClusterListingProps) {
-  let listing = props.clusters.map((cluster) => {
+  const listing = props.clusters.map((cluster) => {
     return (
       <ClusterListingItem
         isActive={cluster.id === props.activeClusterId}
@@ -716,13 +716,13 @@ function ClusterListingItem(props: IClusterListingItemProps) {
   let cluster_state = "Stopped";
   if (cluster.controller) {
     cluster_state = cluster.controller.state.state;
-    if (cluster_state == "after") {
+    if (cluster_state === "after") {
       cluster_state = "Stopped";
     }
   }
 
   // stop action is 'delete' for already-stopped clusters
-  let STOP = cluster_state === "Stopped" ? "DELETE" : "STOP";
+  const STOP = cluster_state === "Stopped" ? "DELETE" : "STOP";
 
   return (
     <li
@@ -749,7 +749,7 @@ function ClusterListingItem(props: IClusterListingItemProps) {
         />
         <button
           className={`ipp-ClusterListingItem-button ipp-ClusterListingItem-start jp-mod-styled ${
-            cluster_state == "Stopped" ? "" : "ipp-hidden"
+            cluster_state === "Stopped" ? "" : "ipp-hidden"
           }`}
           onClick={async (evt) => {
             evt.stopPropagation();

lab/src/dialog.tsx

@@ -62,8 +62,7 @@ export class NewCluster extends React.Component<
    */
   constructor(props: NewCluster.IProps) {
     super(props);
-    let model: INewCluster;
-    model = props.initialModel;
+    const model: INewCluster = props.initialModel;
 
     this.state = { model };
   }
@@ -74,7 +73,7 @@ export class NewCluster extends React.Component<
    * be sent as the result of the dialog.
    */
   componentDidUpdate(): void {
-    let model: INewCluster = { ...this.state.model };
+    const model: INewCluster = { ...this.state.model };
     this.props.stateEscapeHatch(model);
   }
 
@@ -171,7 +170,7 @@ export class NewCluster extends React.Component<
  *
  * @param model: the initial model.
  *
- * @returns a promse that resolves with the user-selected Dialogs for the
+ * @returns a promise that resolves with the user-selected Dialogs for the
  *   cluster model. If they pressed the cancel button, it resolves with
  *   the original model.
  */

lab/src/index.ts

@@ -53,6 +53,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
   activate,
   id: PLUGIN_ID,
   requires: [IConsoleTracker, INotebookTracker, ISettingRegistry, IStateDB],
+  description: "Manage IPython Parallel clusters from the JupyterLab sidebar.",
   optional: [ILabShell],
   autoStart: true,
 };
@@ -76,7 +77,7 @@ async function activate(
   const id = "ipp-cluster-launcher";
 
   const isLab = !!labShell;
-  const isRetroTree = PageConfig.getOption("retroPage") == "tree";
+  const isRetroTree = PageConfig.getOption("retroPage") === "tree";
 
   const clientCodeInjector = async (model: IClusterModel) => {
     const editor = await Private.getCurrentEditor(
@@ -177,7 +178,7 @@ async function activate(
 
   // Whether the cluster clients should aggressively inject themselves
   // into the current session.
-  let autoStartClient: boolean = false;
+  const autoStartClient: boolean = false;
 
   // Update the existing trackers and signals in light of a change to the
   // settings system. In particular, this reacts to a change in the setting
@@ -246,6 +247,7 @@ async function activate(
   // If either is not found, it bails.
   app.commands.addCommand(CommandIDs.injectClientCode, {
     label: "Inject IPython Client Connection Code",
+    describedBy: {},
     execute: async () => {
       const cluster = Private.clusterFromClick(app, sidebar.clusterManager);
       if (!cluster) {
@@ -258,6 +260,7 @@ async function activate(
   // Add a command to launch a new cluster.
   app.commands.addCommand(CommandIDs.newCluster, {
     label: (args) => (args["isPalette"] ? "Create New Cluster" : "NEW"),
+    describedBy: {},
     execute: () => sidebar.clusterManager.create(),
     iconClass: (args) =>
       args["isPalette"] ? "" : "jp-AddIcon jp-Icon jp-Icon-16",
@@ -273,6 +276,7 @@ async function activate(
   // Add a command to launch a new cluster.
   app.commands.addCommand(CommandIDs.startCluster, {
     label: "Start Cluster",
+    describedBy: {},
     execute: () => {
       const cluster = Private.clusterFromClick(app, sidebar.clusterManager);
       if (!cluster) {
@@ -285,6 +289,7 @@ async function activate(
   // Add a command to stop a cluster.
   app.commands.addCommand(CommandIDs.stopCluster, {
     label: "Shutdown Cluster",
+    describedBy: {},
     execute: () => {
       const cluster = Private.clusterFromClick(app, sidebar.clusterManager);
       if (!cluster) {
@@ -297,6 +302,7 @@ async function activate(
   // Add a command to resize a cluster.
   app.commands.addCommand(CommandIDs.scaleCluster, {
     label: "Scale Cluster…",
+    describedBy: {},
     execute: () => {
       const cluster = Private.clusterFromClick(app, sidebar.clusterManager);
       if (!cluster) {
@@ -361,11 +367,6 @@ async function activate(
 }
 
 namespace Private {
-  /**
-   * A private counter for ids.
-   */
-  export let id = 0;
-
   /**
    * Whether a kernel should be used. Only evaluates to true
    * if it is valid and in python.
@@ -438,7 +439,7 @@ rc`;
   ): Kernel.IKernelConnection | null | undefined {
     // Get a handle on the most relevant kernel,
     // whether it is attached to a notebook or a console.
-    let current = shell.currentWidget;
+    const current = shell.currentWidget;
     let kernel: Kernel.IKernelConnection | null | undefined;
     if (current && notebookTracker.has(current)) {
       kernel = (current as NotebookPanel).sessionContext.session?.kernel;
@@ -467,7 +468,7 @@ rc`;
   ): Promise<CodeEditor.IEditor | null | undefined> {
     // Get a handle on the most relevant kernel,
     // whether it is attached to a notebook or a console.
-    let current = app.shell.currentWidget;
+    const current = app.shell.currentWidget;
     let editor: CodeEditor.IEditor | null | undefined;
     if (current && notebookTracker.has(current)) {
       NotebookActions.insertAbove((current as NotebookPanel).content);

lab/src/sidebar.ts

@@ -13,7 +13,7 @@ export class Sidebar extends Widget {
   constructor(options: Sidebar.IOptions) {
     super();
     this.addClass("ipp-Sidebar");
-    let layout = (this.layout = new PanelLayout());
+    const layout = (this.layout = new PanelLayout());
 
     const injectClientCodeForCluster = options.clientCodeInjector;
     const getClientCodeForCluster = options.clientCodeGetter;