Skip to content

Commit e8f9e36

Browse files
authored
Merge pull request #955 from minrk/backport
backport ipykernel 7 fix
2 parents bfac015 + 8be345c commit e8f9e36

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ env:
2121

2222
jobs:
2323
test:
24-
runs-on: ${{ matrix.runs_on || 'ubuntu-20.04' }}
24+
runs-on: ${{ matrix.runs_on || 'ubuntu-22.04' }}
2525
timeout-minutes: 20
2626

2727
strategy:
@@ -42,8 +42,8 @@ jobs:
4242
- python: "3.9"
4343
env:
4444
IPP_ENABLE_CURVE: "1"
45-
- python: "3.8"
46-
runs_on: windows-2019
45+
- python: "3.9"
46+
runs_on: windows-2022
4747
- python: "3.9"
4848
runs_on: macos-14
4949
- python: "3.11"

docs/source/changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ Changes in IPython Parallel
66

77
## 9.0
88

9+
### 9.0.2 - 2025-10
10+
11+
([full changelog](https://github.com/ipython/ipyparallel/compare/9.0.1...9.0.2))
12+
13+
9.0.2 fixes compatibility with upcoming ipykernel 7 (as of alpha 3).
14+
915
### 9.0.1 - 2025-03
1016

1117
([full changelog](https://github.com/ipython/ipyparallel/compare/9.0.0...9.0.1))

docs/source/conf.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,10 @@
384384
"https://github.com/search", # github search links
385385
"https://github.com/ipython/ipyparallel/compare/", # too many comparisons in changelog
386386
r"https?://(localhost|127.0.0.1).*", # ignore localhost references in auto-links
387+
# requests from CI blocked
388+
r"https://www.mcs.anl.gov/.*",
389+
r"https://www.mcs.anl.gov/.*",
390+
r"https://urn.nb.no/.*",
387391
]
388392

389393
# myst_nb execution

docs/source/tutorial/intro.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ The {class}`~.ipyparallel.Cluster` and {class}`~.ipyparallel.Client` classes can
228228
for easier cleanup of resources.
229229

230230
- Entering a `Cluster` context
231-
232231
1. starts the cluster
233232
2. waits for engines to be ready
234233
3. connects a client

ipyparallel/engine/app.py

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -720,17 +720,13 @@ def send_with_metadata(
720720
kernel_kwargs["control_thread"] = control_thread = ControlThread(
721721
daemon=True
722722
)
723-
if ipykernel.version_info >= (7,):
724-
kernel_kwargs["shell_socket"] = zmq.asyncio.Socket(shell_socket)
725-
kernel_kwargs["control_socket"] = zmq.asyncio.Socket(control_socket)
726-
else:
727-
# Kernel.start starts control thread in kernel 7
728-
control_thread.start()
729-
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(
730-
control_socket, control_thread.io_loop
731-
)
732723

733-
kernel_kwargs["shell_streams"] = [zmqstream.ZMQStream(shell_socket)]
724+
control_thread.start()
725+
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(
726+
control_socket, control_thread.io_loop
727+
)
728+
729+
kernel_kwargs["shell_streams"] = [zmqstream.ZMQStream(shell_socket)]
734730

735731
self.kernel = Kernel.instance(
736732
parent=self,
@@ -954,12 +950,7 @@ def initialize(self, argv=None):
954950
self.forward_logging()
955951

956952
def init_signal(self):
957-
if ipykernel.version_info >= (7,):
958-
# ipykernel 7 changes SIGINT handling
959-
# to the app instead of the kernel
960-
self.kernel_app.init_signal()
961-
else:
962-
signal.signal(signal.SIGINT, self._signal_sigint)
953+
signal.signal(signal.SIGINT, self._signal_sigint)
963954
signal.signal(signal.SIGTERM, self._signal_stop)
964955

965956
def _signal_sigint(self, sig, frame):

ipyparallel/nbextension/static/clusterlist.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,8 @@ define(["base/js/namespace", "jquery", "base/js/utils"], function (
199199
that.cluster_list.load_list();
200200
},
201201
error: function (xhr, status, error) {
202-
utils.log_ajax_error(xhr, status, error),
203-
status_col.text("error stopping cluster");
202+
(utils.log_ajax_error(xhr, status, error),
203+
status_col.text("error stopping cluster"));
204204
},
205205
};
206206
status_col.text("stopping");

0 commit comments

Comments
 (0)