feat(app): iterate Configurable base-classes for non app.classes lists#380
Merged
Conversation
## Context The methods `App._classes_inc_parents()` & `App._classes_with_config_traits()` are really useful when traversing mro of base-classes in user code (e.g. printing config-value categories, pre-validation checks). Currently those work directly on the :attr:`Application.classes` only. With this change, user code cat utilize these methods for implementing custom logic.
Carreau
added
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The methods
App._classes_inc_parents()&App._classes_with_config_traits()are really useful when traversingmro of base-classes in user code (e.g. printing config-value categories,
pre-validation checks). Currently those work directly on the
:attr:
Application.classesonly, and need to copy their code to emulate them.Solution
This change adds an optional
classesargument to those 2 methods that override the :attrclasses.User code can utilize these methods for implementing custom logic on any class-list.