Skip to content

refact(log): consolidate some duplicate log statements#424

Merged
minrk merged 1 commit into
ipython:masterfrom
ankostis:logdupes
Aug 8, 2017
Merged

refact(log): consolidate some duplicate log statements#424
minrk merged 1 commit into
ipython:masterfrom
ankostis:logdupes

Conversation

@ankostis
Copy link
Copy Markdown
Contributor

@ankostis ankostis commented Jul 1, 2017

Use string interpolation for printing log arguments instead of another multiple log statements.

@ankostis
Copy link
Copy Markdown
Contributor Author

ankostis commented Jul 1, 2017

Note that the log-statement about change in Application.config observer fires even if the configuration dictionary is empty.
And this always happen at least once, when the class gets constructed (configurations are loaded later, on initialize()) so debug-logs have some redundant info.

Question: Would it make sense to avoid a debug log-line if config is empty?
(it might still be useful when debugging cases where configs come up empty, while they shouldn't, [edit:] but there are other way to discover that)

@ankostis
Copy link
Copy Markdown
Contributor Author

ankostis commented Jul 5, 2017

Also this log-statement in traitlets.config.Loader#718 deserves to be error-level. On a respective problem for flags, below, it raises.

Should i fix add this in this PR?

@minrk minrk merged commit 389bb8f into ipython:master Aug 8, 2017
@Carreau Carreau added this to the 5.0 milestone Jun 4, 2020
@Carreau Carreau added 5.0-re-review Need to re-review for potential API impact changes. 5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) and removed 5.0-re-review Need to re-review for potential API impact changes. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants