Drop dependency on decorator package#464
Merged
Merged
Conversation
Carreau
added
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the weekend, all Jupyter applications were briefly broken by decorator 4.2.0, before being promptly fixed by version 4.2.1.
While this case has already been resolved, I don't think that the convenience of saving a few lines of code is worth the added risk of an external dependency right at the base of our stack. It only seems to be used in one place in traitlets. I'm proposing that we drop the dependency for traitlets and implement
@catch_config_errorusing standard Python tools.