Tidy generate_release_artifacts.py: imports at top, drop _dt alias

Author: pelson

xkcd-script/generator/generate_release_artifacts.py

@@ -2,10 +2,21 @@
 
 from __future__ import annotations
 
+import argparse
+import datetime
+import pathlib
 import re
 
+from fontTools.ttLib import TTFont
+
 _VERSION_RE = re.compile(r"^\d{4}\.\d+$")
 _DEV_VERSION = "0.0-dev"
+_HEAD_ALLOWED_DIFF = frozenset({"fontRevision", "modified", "checksumAdjustment"})
+_NAME_ALLOWED_DIFF = frozenset({5})
+
+
+class TableMismatch(Exception):
+    """Raised when a verified font table differs from its expected baseline."""
 
 
 def validate_version(version: str) -> None:
@@ -18,9 +29,6 @@ def validate_version(version: str) -> None:
         )
 
 
-from fontTools.ttLib import TTFont
-
-
 def patch_font(font: TTFont, *, version: str, build_date: str) -> None:
     """Patch name table version + head.fontRevision in-place."""
     validate_version(version)
@@ -41,14 +49,6 @@ def patch_font(font: TTFont, *, version: str, build_date: str) -> None:
         font["head"].fontRevision = float(version)
 
 
-class TableMismatch(Exception):
-    """Raised when a verified font table differs from its expected baseline."""
-
-
-_HEAD_ALLOWED_DIFF = frozenset({"fontRevision", "modified", "checksumAdjustment"})
-_NAME_ALLOWED_DIFF = frozenset({5})
-
-
 def verify_tables_identical(*, original: TTFont, patched: TTFont) -> None:
     """Raise TableMismatch if any table differs outside the allowed fields."""
     # GlyphOrder is a virtual table fontTools exposes but never serialises.
@@ -78,20 +78,20 @@ def _verify_head(orig, patched) -> None:
 
 
 def _verify_name(orig, patched) -> None:
-    def key(r):
-        return (r.nameID, r.platformID, r.platEncID, r.langID)
+    def key(record):
+        return (record.nameID, record.platformID, record.platEncID, record.langID)
 
     orig_records = {key(r): str(r) for r in orig.names}
     patched_records = {key(r): str(r) for r in patched.names}
 
     if set(orig_records) != set(patched_records):
         raise TableMismatch("name table record set differs")
 
-    for k, original_value in orig_records.items():
-        if k[0] in _NAME_ALLOWED_DIFF:
+    for record_key, original_value in orig_records.items():
+        if record_key[0] in _NAME_ALLOWED_DIFF:
             continue
-        if patched_records[k] != original_value:
-            raise TableMismatch(f"name record {k} changed unexpectedly")
+        if patched_records[record_key] != original_value:
+            raise TableMismatch(f"name record {record_key} changed unexpectedly")
 
 
 def _verify_generic(tag: str, original: TTFont, patched: TTFont) -> None:
@@ -113,15 +113,12 @@ def inject_js_version(source: str, *, version: str, build_date: str) -> str:
     return header + runtime + source
 
 
-import argparse
-import datetime as _dt
-import pathlib
-
-
 def _ttf_seconds(build_date: str) -> int:
     """Seconds since 1904-01-01 for *build_date* (YYYY-MM-DD, UTC midnight)."""
-    epoch = _dt.datetime(1904, 1, 1, tzinfo=_dt.timezone.utc)
-    when = _dt.datetime.strptime(build_date, "%Y-%m-%d").replace(tzinfo=_dt.timezone.utc)
+    epoch = datetime.datetime(1904, 1, 1, tzinfo=datetime.timezone.utc)
+    when = datetime.datetime.strptime(build_date, "%Y-%m-%d").replace(
+        tzinfo=datetime.timezone.utc
+    )
     return int((when - epoch).total_seconds())
 
 
@@ -160,13 +157,13 @@ def regenerate_woff2(patched_otf: pathlib.Path, out_path: pathlib.Path) -> None:
 
 
 def main(argv: list[str] | None = None) -> int:
-    p = argparse.ArgumentParser(description=__doc__)
-    p.add_argument("--version", required=True)
-    p.add_argument("--font-dir", type=pathlib.Path, required=True)
-    p.add_argument("--js", type=pathlib.Path, required=True)
-    p.add_argument("--out-dir", type=pathlib.Path, required=True)
-    p.add_argument("--build-date", default=_dt.date.today().isoformat())
-    args = p.parse_args(argv)
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument("--version", required=True)
+    parser.add_argument("--font-dir", type=pathlib.Path, required=True)
+    parser.add_argument("--js", type=pathlib.Path, required=True)
+    parser.add_argument("--out-dir", type=pathlib.Path, required=True)
+    parser.add_argument("--build-date", default=datetime.date.today().isoformat())
+    args = parser.parse_args(argv)
 
     validate_version(args.version)
     args.out_dir.mkdir(parents=True, exist_ok=True)
@@ -184,8 +181,12 @@ def main(argv: list[str] | None = None) -> int:
     if not ttf_in.exists():
         raise FileNotFoundError(ttf_in)
 
-    write_patched_font(otf_in, otf_out, version=args.version, build_date=args.build_date)
-    write_patched_font(ttf_in, ttf_out, version=args.version, build_date=args.build_date)
+    write_patched_font(
+        otf_in, otf_out, version=args.version, build_date=args.build_date
+    )
+    write_patched_font(
+        ttf_in, ttf_out, version=args.version, build_date=args.build_date
+    )
     regenerate_woff(otf_out, woff_out)
     regenerate_woff2(otf_out, woff2_out)