Gemification#2
Open
kelsin wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys, while irccloud was down tonight I was looking for tiny things to do and I decided to gemify this growler.rb file since I was hoping to use it!
I don't know if this was needed or if my style or choices made while doing this are wanted but if it helps this is ready to be made into a gem called irccloud-notifier. It uses bundler and includes a binary to run it. Nothing except style changes were done to the actual code.
It's not fully tested but I will do that more once irccloud is back up and working.
I really love irccloud, let me know if there is anything else to help with.
Thanks,
Chris