[sts] require clients to ignore missing policy parts.#443
Merged
Conversation
Also clarify part requirements and connection types
progval
reviewed
Feb 28, 2021
| * A **preload policy**, expressed via the [`preload` key](#the-preload-key) over a secure connection. *OPTIONAL* | ||
| * An **upgrade policy**, expressed via the [`port` key](#the-port-key). *REQUIRED* on an insecure connection. | ||
| * A **persistence policy**, expressed via the [`duration` key](#the-duration-key) *REQUIRED* on a secure connection. | ||
| * A **preload policy**, expressed via the [`preload` key](#the-preload-key) *OPTIONAL* on a secure connection. |
Contributor
There was a problem hiding this comment.
nitpick: "OPTIONAL on a secure connection." seems to imply that it isn't optional on an insecure connection, ie. that it is required. The existing wording was less ambiguous for that item.
Member
Author
There was a problem hiding this comment.
I think that interpretation would have to be a deliberately dishonest misinterpretation.
Member
Author
|
Will merge this in a couple days if there are no outstanding comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clarify part requirements and connection types
This follows up from #390 (comment) and makes the requirements a bit clearer.
The goal here is to allow for potential policy extension in future without breaking existing implementations.