Skip to content

message-tags: forbid duplicate tags in CLIENTTAGDENY#600

Open
emersion wants to merge 1 commit intoircv3:masterfrom
emersion:clienttagdeny-dup
Open

message-tags: forbid duplicate tags in CLIENTTAGDENY#600
emersion wants to merge 1 commit intoircv3:masterfrom
emersion:clienttagdeny-dup

Conversation

@emersion
Copy link
Copy Markdown
Contributor

Main motivation is to disallow the following case:

CLIENTTAGDENY=foo,-foo

Main motivation is to disallow the following case:

    CLIENTTAGDENY=foo,-foo
@ArsenArsen
Copy link
Copy Markdown

in similar vein, could we forbid * anywhere but in the first list item? i.e. make CLIENTTAGDENY=-foo,* and CLIENTTAGDENY=foo,* invalid

@emersion
Copy link
Copy Markdown
Contributor Author

While I'm confident that no existing server sends CLIENTTAGDENY=foo,-foo, I wouldn't say the same about * being first. Additionally, CLIENTTAGDENY=foo,-foo is nonsensical while * position would be mainly about simplifying parsing.

@ArsenArsen
Copy link
Copy Markdown

IMO it's not more sensible since, for any tag list T, and any tag list without star elements T2, T,*,T2is equivalent to *,T2

@ArsenArsen
Copy link
Copy Markdown

ah, nevermind, that clause exists already; I just missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants