[HAL][AMDGPU] Support raw HSACO custom kernargs#24512
Open
AWoloszyn wants to merge 1 commit into
Open
Conversation
Allow AMDGPU raw HSACO modules to expose HIP-visible kernel symbols that have companion kernel descriptors, even when the code object metadata only describes a subset of exports. Preserve native kernarg layouts for those raw kernels by widening reflected parameter sizes and offsets, accepting pre-packed HIP argument blobs that omit trailing ABI padding, zero-filling missing bytes, and synthesizing HIP implicit args at the metadata-derived or HSA-reported suffix offset. Use ELF symbol metadata and kernel descriptors to identify additional raw code object exports and keep their dispatch ABI consistent with the loaded HSA executable. Signed-off-by: Andrew Woloszyn <andrew.woloszyn@gmail.com>
AWoloszyn
force-pushed
the
users/awoloszyn/amdgpu-hsaco-custom-kernargs
branch
from
cedf5e0 to
57ac1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow AMDGPU raw HSACO modules to expose HIP-visible kernel symbols that have companion kernel descriptors, even when the code object metadata only describes a subset of exports.
Preserve native kernarg layouts for those raw kernels by widening reflected parameter sizes and offsets, accepting pre-packed HIP argument blobs that omit trailing ABI padding, zero-filling missing bytes, and synthesizing HIP implicit args at the metadata-derived or HSA-reported suffix offset.
Use ELF symbol metadata and kernel descriptors to identify additional raw code object exports and keep their dispatch ABI consistent with the loaded HSA executable.