Emit torch.vtensor.literal for small initializers#36
Open
jtuyls wants to merge 1 commit into
Open
Conversation
jtuyls
force-pushed
the
vtensor-literal-constants-v2
branch
from
7af0aec to
63efe40
Compare
Small initializers (<=256 bytes) now emit torch.vtensor.literal instead of flow.tensor.constant + torch_c.from_builtin_tensor. This allows torch-mlir conversion patterns to directly match constant values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jorn <jorn.tuyls@gmail.com>
jtuyls
force-pushed
the
vtensor-literal-constants-v2
branch
from
63efe40 to
13d7348
Compare
Groverkss
reviewed
Apr 13, 2026
Collaborator
Groverkss
left a comment
Groverkss
left a comment
There was a problem hiding this comment.
I don't think this should be needed. The folder for from_builtin... should fold any constant like operation. Can you check if the folders are working correctly? We already don't use dialect resources for small initializers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small initializers (<=256 bytes) now emit torch.vtensor.literal instead of flow.tensor.constant + torch_c.from_builtin_tensor. This allows torch-mlir conversion patterns to directly match constant values.