Bump k8s.io/* deps to v1.35 - #576
Conversation
48a2b01 to
282d144
Compare
📝 WalkthroughWalkthroughBumps Go and dependency versions, refactors EnsureLoadBalancer and LoadBalancerRouting to use apply-configuration Apply calls, updates tests to use pointer booleans for owner refs, and bumps envtest Kubernetes version to 1.35.0. ChangesLoad balancer refactoring with dependency updates
🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 12-19: The go.mod lists mixed Kubernetes minor versions; change
the direct module entries for k8s.io/cloud-provider and
k8s.io/controller-manager to the same v0.35.x line used by the other k8s.io
modules (e.g., v0.35.3) so all k8s.io/* dependencies share the same minor, then
update/sync modules with your Go tooling (module download/tidy) to ensure the
lockfile and transitive deps are consistent; target the symbols
k8s.io/cloud-provider and k8s.io/controller-manager when making the edits.
In `@pkg/cloudprovider/ironcore/load_balancer.go`:
- Around line 212-239: The internal LoadBalancer IP allocation hardcodes
v1.IPv4Protocol; change the logic where spec.WithIPs(...) is built (inside the
loadBalancerType == networkingv1alpha1 block) to derive the PrefixSpec IP family
from service.Spec.IPFamilies instead of hardcoding IPv4: validate
service.Spec.IPFamilies (e.g., ensure at least one family, reject unsupported
dual-stack combinations or choose a deterministic family like the first entry),
map v1.IPv4Protocol/v1.IPv6Protocol appropriately and pass that value to
ipamv1alpha1ac.PrefixSpec().WithIPFamily rather than using v1.IPv4Protocol,
keeping existing checks for o.cloudConfig.PrefixName and the rest of the
EphemeralPrefixSource construction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0cc0f912-ada1-403c-8627-08c956c7fba5
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.modpkg/cloudprovider/ironcore/load_balancer.gopkg/cloudprovider/ironcore/suite_test.go
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/cloudprovider/ironcore/load_balancer.go`:
- Around line 350-356: The OwnerReference built with metav1ac.OwnerReference()
only sets APIVersion/Kind/Name/UID and must include Controller and
BlockOwnerDeletion set to true to match the prior controller reference behavior;
update the builder chain where metav1ac.OwnerReference() is used (the current
WithAPIVersion(...).WithKind("LoadBalancer").WithName(loadBalancer.Name).WithUID(loadBalancer.UID)
block) to also set Controller and BlockOwnerDeletion to true (use the
appropriate WithController(...) and WithBlockOwnerDeletion(...) builder methods
or supply pointer bools as the apply-config expects) so the resulting reference
is a controller owner reference and enables block owner deletion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 02413a0e-0268-47dd-b0f3-01e08961f59a
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
pkg/cloudprovider/ironcore/load_balancer.gopkg/cloudprovider/ironcore/suite_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/cloudprovider/ironcore/suite_test.go
Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
282d144 to
efb3f2e
Compare
Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
Proposed Changes
Summary by CodeRabbit
Chores
Tests
Refactor