Skip to content

Remove paths-ignore filters from required workflows - #587

Merged
gonzolino merged 1 commit into
ironcore-dev:mainfrom
gonzolino:chore/path-filters
Jul 17, 2026
Merged

Remove paths-ignore filters from required workflows#587
gonzolino merged 1 commit into
ironcore-dev:mainfrom
gonzolino:chore/path-filters

Conversation

@gonzolino

@gonzolino gonzolino commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Remove path-ignore from triggers of required workflows so they do not block
    PRs

Summary by CodeRabbit

  • Chores
    • Pull requests that modify documentation or Markdown files now run the standard checks.
    • Kustomize validation is now triggered for documentation and Markdown-only pull requests.
    • Kustomize validation now explicitly runs the project’s validation script.

Signed-off-by: Daniel Gonzalez Nothnagel <daniel.gonzalez.nothnagel@sap.com>
@gonzolino
gonzolino requested a review from a team as a code owner July 17, 2026 11:58
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b4c0a4a6-413a-41c8-b724-fc0040ab4f92

📥 Commits

Reviewing files that changed from the base of the PR and between d814d7d and 3fee107.

📒 Files selected for processing (2)
  • .github/workflows/clean.yml
  • .github/workflows/kustomize-validation.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/clean.yml

📝 Walkthrough

Walkthrough

Pull request workflows no longer ignore documentation-only changes. The Kustomize validation workflow also explicitly runs ./hack/validate-kustomize.sh.

Changes

CI workflow updates

Layer / File(s) Summary
Workflow triggers and validation execution
.github/workflows/clean.yml, .github/workflows/kustomize-validation.yml
Removed documentation path exclusions from both pull request workflows and added an explicit Kustomize validation script invocation.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: afritzler

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing paths-ignore filters from required workflows.
Description check ✅ Passed The description includes the main Proposed Changes section, but it is brief and omits the template's Fixes # line.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gonzolino
gonzolino merged commit 1464801 into ironcore-dev:main Jul 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants