Skip to content

Fix deprecations in kustomizations - #590

Merged
afritzler merged 1 commit into
ironcore-dev:mainfrom
sap-contributions:chore/589-fix-deprecations-in-kustomizations
Jul 24, 2026
Merged

Fix deprecations in kustomizations#590
afritzler merged 1 commit into
ironcore-dev:mainfrom
sap-contributions:chore/589-fix-deprecations-in-kustomizations

Conversation

@friegger

@friegger friegger commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #589

Summary by CodeRabbit

  • Chores
    • Standardized Kubernetes Kustomize manifests with explicit API versions and resource types.
    • Updated deployment configuration to target the kube-system namespace.
    • Modernized patch configuration and secret file declarations for improved compatibility with current Kustomize tooling.
    • Simplified the default deployment resource selection.
    • Reformatted RBAC resource definitions without changing their behavior.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger
friegger requested a review from a team as a code owner July 22, 2026 11:15
@github-actions github-actions Bot added bug Something isn't working chore labels Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d164a4c2-a621-4eba-bc1e-f765d45b6903

📥 Commits

Reviewing files that changed from the base of the PR and between 30a8ee1 and 40f2c65.

📒 Files selected for processing (5)
  • config/config/kustomization.yaml
  • config/default/kustomization.yaml
  • config/kind/kustomization.yaml
  • config/manager/kustomization.yaml
  • config/rbac/kustomization.yaml

📝 Walkthrough

Walkthrough

Changes

Kustomization updates

Layer / File(s) Summary
Manifest metadata and resource declarations
config/config/kustomization.yaml, config/default/kustomization.yaml, config/manager/kustomization.yaml, config/rbac/kustomization.yaml
Kustomization metadata is made explicit, resource references are preserved or narrowed, and RBAC resource formatting is updated.
Kind Kustomize field migration
config/kind/kustomization.yaml
The manifest adopts v1beta1, replaces patchesStrategicMerge with patches, and preserves the generated secret sources and names.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • ironcore-dev/libvirt-provider#757 — Covers the same Kustomize deprecation migration from patchesStrategicMerge to patches.
  • ironcore-dev/ceph-provider#905 — Covers equivalent Kustomize manifest updates and deprecated patch-field replacement.
  • ironcore-dev/ironcore#1521 — Directly matches the config/kind/kustomization.yaml deprecation fix.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only says "Fixes #589" and is missing the required Proposed Changes section. Add the three Proposed Changes bullets and keep the Fixes # line so the template is complete.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: fixing deprecated kustomization usage.
Linked Issues check ✅ Passed The PR replaces patchesStrategicMerge with patches, matching the linked issue's deprecation fix.
Out of Scope Changes check ✅ Passed The edits stay within kustomization manifests and deprecation cleanup, with no clearly unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afritzler afritzler removed the bug Something isn't working label Jul 24, 2026
@afritzler
afritzler merged commit 9ce2954 into ironcore-dev:main Jul 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deprecations in kustomizations

2 participants